-
Notifications
You must be signed in to change notification settings - Fork 54
CCNueFilter (develop PR) #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @lynnt20, thanks for this! Looks good to me, happy to approve once you finish your tests. Also, and I know you said it partially addresses #655, just to make sure I am up to date: this filter only selects (a)nue CC events in the TPC, so we still need numu CC dirt events, which we would need to produce in a separate path and then merge, correct? |
|
Hi @marcodeltutto, just to follow up on your previous comment (and summarize what we just figured out offline), this filter will now select events with AV nueCC interactions and include numu dirt within the same event. So for the purpose of creating a rockbox sample with AV nueCC and dirt interactions, the gen fcl fulfills both of these conditions. |
|
@lynnt20 I think this PR reverts some commits that are in develop, I don't think this is intended? |
|
Yes sorry about that everyone.. I need to do some cleanup for both of the branches |
This reverts commit d5e3270.
|
@marcodeltutto @lyates17 This isn't officially reviewed, but I will consider it as "approved" since the identical develop PR did get approved and merged in. |
|
trigger build ci_ref=v10_06_01 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndcode@v10_06_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnanaobj@v10_00_04 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/sbnalg@v10_06_00_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |

Description
Filters/filters.fclfor a charged-current electron-neutrino interaction inside the TPC active volume.Partially resolves issue #655.
Currently testing, will update from draft to ready when test files look sensible.Checklist
Reviewers,AssigneesDevelopement