Skip to content

Conversation

@lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Jul 2, 2025

Description

  • Adds a new fcl block inside Filters/filters.fcl for a charged-current electron-neutrino interaction inside the TPC active volume.
  • Adds a new gen fcl that runs rockbox + the ccnue filter

Partially resolves issue #655. Currently testing, will update from draft to ready when test files look sensible.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • [N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • [N/A] Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

@lynnt20 lynnt20 self-assigned this Jul 2, 2025
@lynnt20 lynnt20 added enhancement New feature or request simulation genie or geant4 (g4) labels Jul 2, 2025
@marcodeltutto
Copy link
Member

Hi @lynnt20, thanks for this! Looks good to me, happy to approve once you finish your tests.

Also, and I know you said it partially addresses #655, just to make sure I am up to date: this filter only selects (a)nue CC events in the TPC, so we still need numu CC dirt events, which we would need to produce in a separate path and then merge, correct?

@lynnt20
Copy link
Contributor Author

lynnt20 commented Jul 8, 2025

Hi @marcodeltutto, just to follow up on your previous comment (and summarize what we just figured out offline), this filter will now select events with AV nueCC interactions and include numu dirt within the same event. So for the purpose of creating a rockbox sample with AV nueCC and dirt interactions, the gen fcl fulfills both of these conditions.

@lynnt20
Copy link
Contributor Author

lynnt20 commented Jul 8, 2025

image

Expected efficiency of this filter is ~1%.

@lynnt20 lynnt20 marked this pull request as ready for review July 8, 2025 16:47
@marcodeltutto
Copy link
Member

@lynnt20 I think this PR reverts some commits that are in develop, I don't think this is intended?

@lynnt20
Copy link
Contributor Author

lynnt20 commented Jul 8, 2025

Yes sorry about that everyone.. I need to do some cleanup for both of the branches

@lynnt20 lynnt20 mentioned this pull request Jul 9, 2025
5 tasks
@nathanielerowe
Copy link
Contributor

@marcodeltutto @lyates17 This isn't officially reviewed, but I will consider it as "approved" since the identical develop PR did get approved and merged in.

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_01 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndcode@v10_06_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnanaobj@v10_00_04 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/sbnalg@v10_06_00_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved

@nathanielerowe nathanielerowe merged commit d009296 into develop Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request simulation genie or geant4 (g4)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants