Updates to semi-analytical light simulation: optical path tool

[pgreen135]

Implements SBND optical path tool for semi-analytical model.

Corresponds with larsim PR: LArSoft/larsim#157

[ggamezdiego]

Hi @pgreen135, modifications look clear and fine. Just one minor question, I do not understand the second part of the comment "// check x coordinate has same sign or is close to zero" in SBNDOpticalPath.h. Could you clarify that?

[pgreen135]

Hi @pgreen135, modifications look clear and fine. Just one minor question, I do not understand the second part of the comment "// check x coordinate has same sign or is close to zero" in SBNDOpticalPath.h. Could you clarify that?

Thanks for taking a look @ggamezdiego. That part of the comment was left over from the old implementation that had to also deal with the DUNE-HD 1x2x6 geometry in the same function --- I've push an update to remove that bit to avoid any future confusions.

[nathanielerowe]

Ah, somehow didn't notice the linked review was still pending. Will be waiting until that gets merged in and looped into an sbncode release to merge this.

[pgreen135]

@nathanielerowe this is now ready to be merged and is required for the most recent larsoft release

[nathanielerowe]

Testing this to make sure it resolves a CI issues in another PR

[nathanielerowe]

trigger build

[nathanielerowe]

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq-artdaq-core@v1_10_09 SBNSoftware/sbnd_data@v01_35_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq-artdaq-core@v1_10_09 SBNSoftware/sbnd_data@v01_35_00

[nathanielerowe]

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq-artdaq-core@v1_10_09 SBNSoftware/sbnd_data@v01_35_00

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard