Fix conflicts with new larsim version #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyan-w
moved this from Ready for CI
to Reviewer Approved
in SBND 2025 Fall Production
nathanielerowe
moved this from Reviewer Approved
to Wait for next release
in SBND 2025 Fall Production
nathanielerowe
moved this from Wait for next release
to Reviewer Approved
in SBND 2025 Fall Production
nathanielerowe
moved this from Reviewer Approved
to Ready for CI
in SBND 2025 Fall Production
Contributor
|
Can you rebase this PR onto #819 now that the dust from this morning has settled? I can merge it in there and CI should be able to run on that. |
asanchezcastillo
changed the base branch from
develop
to
bugfix/tpcpmtbfm_upgrade
Contributor
Author
|
@nathanielerowe done! Let me know if everything's fine after the rebasing or you need any other change on my end :) |
nathanielerowe
moved this from Ready for CI
to In tagged release
in SBND 2025 Fall Production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix for #807 after including the new optical path tool in #756 .
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?