Add pmt variations fcls

[asanchezcastillo]

Description

This PR adds the corresponding pmt detvar fcls. The variations are the following:

• Large PMT gain variation
• High PMT baseline noise
• Low PMT detection efficiency
• Combinations of the previous variations

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

• Added at least 1 label from available labels.
• Assigned at least 1 reviewer under Reviewers,
• Assigned all contributers including yourself under Assignees
• Linked any relevant issues under Developement
• Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
• Does this affect the standard workflow?
• Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

[linyan-w]

Looks good to me. Thanks Alejandro.
Note that low eff is the efficiency matching data, but there's no going back changing PMT eff for spring production so producing this as detvar sample.

[nathanielerowe]

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03

[nathanielerowe]

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[nathanielerowe]

Approved!

[linyan-w]

Hi @asanchezcastillo this is supposed to be a PR for spring production. Could you please make an identical PR branching off production/v10_06_00 ?

[lynnt20]

Hi sorry to show up like a ghost @asanchezcastillo , but cherry-picked this commit and noticed that a CMakesList.txt needs to be added to the new subdirectory with the line install_fhicl(), and the new subdirectory also needs to be added to the lower directory CMakesList.txt. In its current version, these fhicls won't be found since they're not being built.

[nathanielerowe]

@asanchezcastillo Can you resolve Lynn's comment?