Skip to content

Conversation

@asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Aug 8, 2025

Description

Production PR corresponding to develop PR #767
$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo asanchezcastillo self-assigned this Aug 8, 2025
@asanchezcastillo asanchezcastillo added the detsim Detector simulation label Aug 8, 2025
@linyan-w linyan-w requested a review from jzennamo August 8, 2025 14:08
Copy link
Contributor

@jzennamo jzennamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this might not work, because the above fcls will still have the "DetSim" Process name written onto the file, they would either need a new process name added to them or maybe I am wrong?

@linyan-w
Copy link
Contributor

linyan-w commented Aug 8, 2025

I think that this might not work, because the above fcls will still have the "DetSim" Process name written onto the file, they would either need a new process name added to them or maybe I am wrong?

Ah yep, if we scrub the full detsim it will work, but the current version won't. Need to change the process name.

@linyan-w
Copy link
Contributor

linyan-w commented Aug 8, 2025

@jzennamo fixed

@linyan-w linyan-w requested a review from jzennamo August 8, 2025 15:51
@linyan-w linyan-w self-assigned this Aug 8, 2025
@jzennamo
Copy link
Contributor

jzennamo commented Aug 8, 2025

awesome! Thanks @linyan-w have you tested that the workflow works on a reco1 file through to another reco1 file?

@linyan-w
Copy link
Contributor

Updated & ready to go. Keeping necessary (SimPhotonsLites) and additional parts (SimEnergyDeposit) for potential other detvars.

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/sbnanaobj@v10_00_04 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_31_00

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved

@nathanielerowe nathanielerowe merged commit 7a89884 into production/v10_06_00 Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detsim Detector simulation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants