-
Notifications
You must be signed in to change notification settings - Fork 54
Add pmt detvar fcls #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pmt detvar fcls #781
Conversation
jzennamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this might not work, because the above fcls will still have the "DetSim" Process name written onto the file, they would either need a new process name added to them or maybe I am wrong?
Ah yep, if we scrub the full detsim it will work, but the current version won't. Need to change the process name. |
|
@jzennamo fixed |
|
awesome! Thanks @linyan-w have you tested that the workflow works on a reco1 file through to another reco1 file? |
|
Updated & ready to go. Keeping necessary (SimPhotonsLites) and additional parts (SimEnergyDeposit) for potential other detvars. |
|
trigger build ci_ref=v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbnobj@v10_01_00 SBNSoftware/sbnanaobj@v10_00_04 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_31_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |
Description
Production PR corresponding to develop PR #767
$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?