-
Notifications
You must be signed in to change notification settings - Fork 54
Coherent Noise Removal Nonuniformity Mitigation #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linyan-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Lynn!
|
trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved |
Description
Adjusts the "signal contamination in correction waveform" threshold during coherent noise removal (
decon_lim), and adds increased front and back padding to the signal protection ROI. Also turns offscalingcalculation for CNR removal coefficient, and sets all scaling = 1.0.Additionally adds bugfix for truth matching (SimChannel etc.) in DepoFluxWriter configuration.
Checklist
Reviewers,AssigneesDevelopementLink(s) to docdb describing changes
Final validation shown in docdb 42693.