Skip to content

Conversation

@lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Jul 29, 2025

Description

Adjusts the "signal contamination in correction waveform" threshold during coherent noise removal (decon_lim), and adds increased front and back padding to the signal protection ROI. Also turns off scaling calculation for CNR removal coefficient, and sets all scaling = 1.0.

Additionally adds bugfix for truth matching (SimChannel etc.) in DepoFluxWriter configuration.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • [N/A] Linked any relevant issues under Developement
  • [N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • [N/A] Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Link(s) to docdb describing changes

Final validation shown in docdb 42693.

@lynnt20 lynnt20 added bug Something isn't working tpc Time Projection Chamber detsim Detector simulation data features for data processing calibration calib ntuple or calib workflow related labels Aug 4, 2025
@lynnt20 lynnt20 self-assigned this Aug 4, 2025
@lynnt20 lynnt20 marked this pull request as ready for review August 4, 2025 17:02
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Lynn!

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved

@nathanielerowe nathanielerowe merged commit 5b6c372 into develop Aug 8, 2025
@linyan-w linyan-w moved this from Todo to In tagged release in SBND 2025 Fall Production Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working calibration calib ntuple or calib workflow related data features for data processing detsim Detector simulation tpc Time Projection Chamber

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

7 participants