Skip to content

Conversation

@sxy1439
Copy link
Contributor

@sxy1439 sxy1439 commented Jul 29, 2025

Description

Please provide a detailed description of the changes this pull request introduces.

This PR is to normalize the charge response for the non-uniformity along the YZ plane. This feature takes the input YZ map and normalizes the dQ/dx of each hit using the correction factor from the corresponding YZ bin where the hit is located. Some printed value of dqdx before and after normalization:

[NormalizeYZ] Plane: 1, TPC: 0, Y: -196.216, Z: 169.939, Scale: 0.957026, dQdx (raw): 1319.81, dQdx (corrected): 1379.07
[NormalizeYZ] Plane: 2, TPC: 1, Y: 169.547, Z: 286.94, Scale: 1.01907, dQdx (raw): 1108.2, dQdx (corrected): 1087.47

This pull and push the dQ/dx depending on whether we are in the high or low charge response region to normalize the charge response throughout the plane.

Attached is also the YZ map from collection plane along the east and west TPCs in the bins of 1x1cm2.
Screen Shot 2025-07-29 at 2 25 20 PM
Screen Shot 2025-07-29 at 2 25 34 PM
Note that this map has been produced with officially processed data sample (1e20 data sample data_MCP2025B_02_DevSample_1e20_bnblight_v10_06_00_02_histreco2_sbnd), which still have non-uniformity due to coherent noise removal issue #772

Additionally, below is the dQ/dx distribution with (red) and without (blue) normalization, which shows narrowing around the peak region after normalization.
Screen Shot 2025-07-29 at 2 34 01 PM

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. No
  • Does this affect the standard workflow? No
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch! will do!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@sxy1439 sxy1439 requested review from linyan-w and mrmooney July 29, 2025 19:45
@sxy1439 sxy1439 self-assigned this Jul 29, 2025
@sxy1439 sxy1439 added the reco1/reco2 Reconstruction label Jul 29, 2025
@linyan-w
Copy link
Contributor

This is a patch that goes into the current (spring) production. @sxy1439 could you please make another PR for the production/v10_06_00 branch?

@nathanielerowe
Copy link
Contributor

@mrmooney @sxy1439 Hello, just a reminder that you will need to review/resolve issues with this PR before I can merge it. Let me know when the corresponding sbnd_data edit is ready and send me the path!

This was referenced Aug 1, 2025
@sxy1439
Copy link
Contributor Author

sxy1439 commented Aug 2, 2025

@nathanielerowe I have the corresponding sbnd_data directory with the YZ maps located at:
/exp/sbnd/app/users/yadav/Calibration/sbndcode_v10_06_01/sbnd_data/
I’ve also created a separate PR for the production/v10_06_00 branch, and since the required files are the same, I believe this same path can be used there as well.

@linyan-w
Copy link
Contributor

linyan-w commented Aug 4, 2025

This PR is ready to merge into develop.
An identical PR #777 patches the spring production.

@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Aug 7, 2025
@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Contributor

Approved!

@nathanielerowe nathanielerowe merged commit 1cb08ca into develop Aug 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants