-
Notifications
You must be signed in to change notification settings - Fork 54
Feature to normalize for YZ non-uniformity #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is a patch that goes into the current (spring) production. @sxy1439 could you please make another PR for the production/v10_06_00 branch? |
|
@nathanielerowe I have the corresponding sbnd_data directory with the YZ maps located at: |
|
This PR is ready to merge into develop. |
|
trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbncode@v10_06_00_04 SBNSoftware/sbnanaobj@v10_00_05 SBNSoftware/sbnobj@v10_01_01 SBNSoftware/sbnalg@v10_06_00_03 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved! |
Description
Please provide a detailed description of the changes this pull request introduces.
This PR is to normalize the charge response for the non-uniformity along the YZ plane. This feature takes the input YZ map and normalizes the dQ/dx of each hit using the correction factor from the corresponding YZ bin where the hit is located. Some printed value of dqdx before and after normalization:
[NormalizeYZ] Plane: 1, TPC: 0, Y: -196.216, Z: 169.939, Scale: 0.957026, dQdx (raw): 1319.81, dQdx (corrected): 1379.07
[NormalizeYZ] Plane: 2, TPC: 1, Y: 169.547, Z: 286.94, Scale: 1.01907, dQdx (raw): 1108.2, dQdx (corrected): 1087.47
This pull and push the dQ/dx depending on whether we are in the high or low charge response region to normalize the charge response throughout the plane.
Attached is also the YZ map from collection plane along the east and west TPCs in the bins of 1x1cm2.


Note that this map has been produced with officially processed data sample (1e20 data sample
data_MCP2025B_02_DevSample_1e20_bnblight_v10_06_00_02_histreco2_sbnd), which still have non-uniformity due to coherent noise removal issue #772Additionally, below is the dQ/dx distribution with (red) and without (blue) normalization, which shows narrowing around the peak region after normalization.

Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?