Skip to content

Conversation

@sxy1439
Copy link
Contributor

@sxy1439 sxy1439 commented Aug 1, 2025

Description

Please provide a detailed description of the changes this pull request introduces.

This PR is to normalize the charge response for the non-uniformity along the YZ plane. More details can be found in PR #773. It is prepared as a patch for the v10_06_00 branch, which corresponds to the CURRENT production campaign started in Spring 2025.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. NO
  • Does this affect the standard workflow? NO
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch! This is for patch release for current production

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? NO

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@sxy1439 sxy1439 requested review from linyan-w and mrmooney August 1, 2025 14:54
@sxy1439 sxy1439 self-assigned this Aug 1, 2025
@sxy1439 sxy1439 added the reco1/reco2 Reconstruction label Aug 1, 2025
@nathanielerowe
Copy link
Contributor

Both PRs say they are trying to merge into develop. Can you modify this? You should see some options for this before you create the branch.

@sxy1439 sxy1439 closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants