Closed
Conversation
Checks whether it is FixedOffset or Autojitter.
This is done to help in adding in Edge correction and make the code more manageable and extendable.
Contributor
Author
|
Fixes #29 |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## devel #40 +/- ##
==========================================
- Coverage 29.14% 0.92% -28.23%
==========================================
Files 36 26 -10
Lines 2628 2281 -347
==========================================
- Hits 766 21 -745
- Misses 1862 2260 +398
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a full refactor of
load_imgto a more object oriented approach. All instruments are now classes that inherit from a generic Instrument parent/base class.This now makes it much easier for me to add a few more fixes for image issues associated with edges. But before I do that, I wanted to merge a full working copy that reproduces the previous load_img functionality and makes it arguably easier to add new instruments.
The plan is to move most of this to an instruments.py file, and keep load_img.py a much smaller file that actually loads images. But that can be left to the future after the edge checking has also been implemented.
I will open some issues to track the other upcoming refactors.
Passing tests locally on python 3.7+ and a manual test of the run_photometry file. (Which we should also add as a unit test?)
Two caveats: we use spaces instead of tabs. This just made it much easier to read these multiline conditionals. I suggest we move to default 4 spaces following most major libraries and python black, as I would like to eventually enable it for automatic code formatting (to reduce code formatting maintenance overhead).
(I did a rebase onto devel before the merge to run the tests and run_photometry as flows table format had changed)