Change tabs to spaces, prepare for black#42
Closed
emirkmo wants to merge 8 commits intoSNflows:develfrom
Closed
Conversation
We move to a 4 space format, Automatically fix Pep8 mistakes that can be auto fixed, and change the Flake8 setup.cfg to match what will happen under black. Currently line limit is set at 120 but that can be discussed.
This was referenced Feb 14, 2022
Closed
Codecov Report
@@ Coverage Diff @@
## devel #42 +/- ##
==========================================
- Coverage 29.15% 28.96% -0.20%
==========================================
Files 36 36
Lines 2627 2627
==========================================
- Hits 766 761 -5
- Misses 1861 1866 +5
Continue to review full report at Codecov.
|
Contributor
Author
|
Closign while figuring out CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes tab indent to 4 spaces in the entire project, to prepare setting up for python black for automatic code formatting.
It also auto applies some common auto-fixable PEP8 stuff (I applied it while doing the indent changes, because why not, we strive to follow PEP8). We also change the setup.cfg for flake8 to be compatible with black and to remove tabs. Good to know that black has its own GitHub actions. So we should set up black and never worry about code formatting again for flows.
(Bonus, we can set up pre-commit hooks on e.g. GitKraken with black.
Specific changes:
Change line limit to 120 characters in setup.cfg but exact number can be discussed. Black default is 88. Project default was 99. We did not enforce it before. We should just pick something that makes it easy to read and set Black to that.
We move to a 4 space indent format.
This PR should be merged before #40 so that GitHub Actions tests can pass.
Fixes #44