Skip to content

fix: Association IRI violation checks (RDFA-449)#75

Open
kiph-soptim wants to merge 22 commits intomainfrom
fix/RDFA-449-Create-associations-on-the-same-class-
Open

fix: Association IRI violation checks (RDFA-449)#75
kiph-soptim wants to merge 22 commits intomainfrom
fix/RDFA-449-Create-associations-on-the-same-class-

Conversation

@kiph-soptim
Copy link
Copy Markdown
Collaborator

Description

The labels of association are now checked to be a unique IRI

Test Checklist

General Behavior

  • Components reload automatically when data changes
  • Editing features are disabled in readonly datasets
  • Dialogs pre-select current dataset/graph
  • Required fields are validated in dialogs
  • Discarding unsaved changes opens a discard cancel confirm dialog

Global MenuBar

  • Navigate to home page works
  • File menu:
    • Import → Graph/SHACL works
    • Export → Graph/SHACL works
    • Share Snapshot works
    • Delete → Dataset/Graph works
  • Edit menu:
    • New → Class works
    • New → Package works
    • Edit/View → Create/Edit/View Ontology works
    • Edit/View → Package works
    • Undo/Redo (Ctrl+Z / Ctrl+Y) works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete → Ontology/Package works
  • View menu:
    • Changelog opens and shows current graph
    • Compare Graphs opens
    • Full SHACL works
  • Help menu:
    • Help link works
    • Submit Feedback link works
    • About navigation works

Welcome Page

  • Navigation to Editor works
  • Tips are displayed
  • Security and data information displayed
  • Copyright and version information displayed

Editor - MenuBar

  • Search function works with all filters (All Datasets, Current Dataset, Current Graph, Current Package)
  • Search finds classes, attributes, associations, packages
  • "Enable Editing" button appears for readonly datasets

Editor - Navigation

  • Hierarchical display (Datasets → Graphs → Packages) works
  • Selection is highlighted
  • Selecting a class does not change dataset/graph/package selection
  • Class selection stays open/highlighted when switching dataset/graph/package
  • Datasets and graphs are collapsible
  • Single click selects; double click or chevron toggles expand/collapse
  • State persists on reload (non-browser)
  • Context menus act on the dataset/graph/package they were opened on
  • Hover labels show prefixes when configured
  • Dataset context menu:
    • Import graph works (disabled in readonly datasets)
    • Share Snapshot works
    • Enable/Disable editing works
    • Manage/View namespaces works
    • Delete dataset works
  • Graph context menu:
    • New package works (disabled in readonly datasets)
    • Undo/Redo works (only enabled when available)
    • Create Ontology
    • Edit Ontology (View Ontology in readonly)
    • Delete Ontology
    • Changelog navigation works
    • Compare dialog works
    • SHACL import/export/full view works (import disabled in readonly datasets)
    • Export graph works
    • Delete graph works (disabled in readonly datasets)
  • Package context menu:
    • Create new class works (disabled in readonly datasets)
    • View/Edit package works
    • Copy URL works
    • Delete package works (disabled for external/default packages and readonly datasets)
  • Class context menu:
    • Open class (editor) works
    • SHACL works
    • Delete class works (disabled in readonly datasets)

Editor - Package View

  • Class diagram displays correctly
  • Moving nodes works and layout changes persist after reload
  • Loading animation shows while loading
  • Info cards show when no package or no classes available
  • Drag and zoom diagram works
  • "Reset View" button works
  • "Filter View" works
  • "Reset Layout" button resets diagram to auto-generated layout
  • Click on class opens class editor

Editor - Class Editor

  • Display and edit class properties: UUID (readonly), Label, Namespace, Package, Derived from, Abstract, Stereotypes, Attributes, Associations, Comment
  • Delete class works
  • Save changes works
  • Discard changes works
  • Attribute Editor works
  • Association Editor works
  • attribute/association SHACL View works
  • Class SHACL View works

Prefixes Page

  • View, add, remove and edit namespaces works

Changelog Page

  • Select graph and display write operations works
  • Operations shown in reverse chronological order
  • Detailed view of changed triples works
  • Restoring graph to a version works

Compare Page

  • Compare two graphs works

kiph-soptim and others added 15 commits April 10, 2026 16:40
The loader was calling ClassPathResource#getFile(), which which only works when the resource exists as a real filesystem file. In a packaged jar it becomes a nested classpath resource, so getFile() throws a FileNotFoundException.
… RDFA-371)

* - added unsaved changes adoption, when saving a class property.

- moved files in model/reactive for better hierarchy

* fixed bugs:
- where previously removed properties were added again when merging 2 classes
- where the property editors didn't clear after creating a new attribute
- Where creating a property would create it 2 times
* refactored navigation to remove faulty api calls

* fixed bugs where:
- default packages were always shown as empty
- no reload happened on enable/disable editing
also added hot reload for undo/redo

* fixed bug, where the package editor didn't work

* fixed bug, where the ontology editor didn't reload properly

* fixed bug where graph navigation section was not updated on modifying data

* fixed bug where undo redo didn't trigger a reload in the class editor
…-class-

Signed-off-by: Philipp Kirchner <philipp.kirchner@soptim.de>
…-class-

Signed-off-by: Philipp Kirchner <philipp.kirchner@soptim.de>
…ssociationEditorDialog opening one of those to edit would create a new association/attribute
…log or AssociationEditorDialog opening one of those to edit would create a new association/attribute"

This reverts commit 33862f8.
Comment thread frontend/src/lib/models/reactive/validity-rules/validityFunctions.js Outdated
Comment thread frontend/src/lib/models/reactive/validity-rules/validityFunctions.js Outdated
Comment thread frontend/src/routes/mainpage/classEditor/classEditor.svelte Outdated
Comment thread frontend/src/routes/mainpage/classEditor/classEditor.svelte Outdated
@spah-soptim spah-soptim dismissed their stale review April 28, 2026 07:43

Review done, LGTM.
Not tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants