Fix!: Pass the model dialect when computing a hash for the column types#4067
Merged
izeigerman merged 1 commit intomainfrom Apr 1, 2025
Merged
Fix!: Pass the model dialect when computing a hash for the column types#4067izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
89faa87 to
503b839
Compare
georgesittas
approved these changes
Apr 1, 2025
Contributor
georgesittas
left a comment
There was a problem hiding this comment.
Is it correct that we don't need a migration script for this because state's not changed?
Collaborator
Author
|
@georgesittas We do need a migration script to trigger the fingerprint re-compute, it just the test didn't catch it, cause we don't have this problem there. Good catch |
503b839 to
0fb7e71
Compare
0fb7e71 to
6a63673
Compare
afzaljasani
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, there can be a mismatch between the hash computed using the original instance of a model and the deserialized one when the type is constructed using the default dialect. (eg.
exp.DataType.build("int")).Example: