Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlmesh/core/model/definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ def _data_hash_values(self) -> t.List[str]:

for column_name, column_type in (self.columns_to_types_ or {}).items():
data.append(column_name)
data.append(column_type.sql())
data.append(column_type.sql(dialect=self.dialect))

for key, value in (self.physical_properties or {}).items():
data.append(key)
Expand Down
5 changes: 5 additions & 0 deletions sqlmesh/migrations/v0077_fix_column_type_hash_calculation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"""Use the model's dialect when calculating the hash for the column types."""


def migrate(state_sync, **kwargs): # type: ignore
pass
17 changes: 17 additions & 0 deletions tests/core/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -8435,3 +8435,20 @@ def test_ignored_rules_serialization():

deserialized_model = SqlModel.parse_raw(model_json)
assert deserialized_model.dict() == model.dict()


def test_data_hash_unchanged_when_column_type_uses_default_dialect():
model = create_sql_model(
"foo",
parse_one("SELECT * FROM bla"),
columns={"a": exp.DataType.build("int")},
dialect="bigquery",
)

deserialized_model = SqlModel.parse_raw(model.json())

assert model.columns_to_types_ == {"a": exp.DataType.build("int")}
assert deserialized_model.columns_to_types_ == {"a": exp.DataType.build("bigint")}

# int == int64 in bigquery
assert model.data_hash == deserialized_model.data_hash