Skip to content

Conversation

@os12
Copy link
Contributor

@os12 os12 commented Jun 15, 2019

  • it returns a UTF-8 string containing the SQL text of prepared statement with
    bound parameters expanded

 - it returns a UTF-8 string containing the SQL text of prepared statement with
   bound parameters expanded
@coveralls
Copy link

coveralls commented Jun 15, 2019

Coverage Status

Coverage increased (+0.04%) to 96.48% when pulling 7dba62b on os12:master into 8191379 on SRombauts:master.

@SRombauts
Copy link
Owner

Hi @os12, thank you for your contribution!
I wasn't even aware of this api.

Would you mind adding at least a basic test in the corresponding unit tests, so that coverall and I are happy?
(if you don't I will, no worries)

Cheers!

@SRombauts SRombauts self-assigned this Jun 16, 2019
 - there is nothing conditional here in the wrapper
@os12
Copy link
Contributor Author

os12 commented Jun 18, 2019

Sure, just added a minimal test.

@SRombauts SRombauts merged commit 9b00034 into SRombauts:master Jun 18, 2019
@SRombauts
Copy link
Owner

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants