Fix a memory leak that came with the Statement::getExtendedSQL() API #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this block must be explicitly free'd, even though other similar things are automatically handled during statement finalization https://www.sqlite.org/c3ref/expanded_sql.html Fix SRombauts#203
Contributor
|
you should not use the auto keyword in this place, since it requires c++11 |
Owner
|
Thank you to you two. For now it makes no sense to drop support for older compiler just for this sort of use of auto. |
Owner
|
For reference, this bug was introduced only a few days ago in #201 |
SRombauts
added a commit
that referenced
this pull request
Jun 24, 2019
Owner
|
I implemented Address Sanitizer to reproduce the problem, and fixed it on master. Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are automatically handled during statement finalization
https://www.sqlite.org/c3ref/expanded_sql.html
Fix #203