krb5_child: use ERR_CHECK_NEXT_AUTH_TYPE instead of EAGAIN #8176
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Kerberos authentication child process to use a new, specific error code ERR_CHECK_NEXT_AUTH_TYPE instead of the generic EAGAIN when an authentication method is not applicable. This is a good improvement as it avoids ambiguity and potential side effects from misinterpreting EAGAIN. The changes are implemented consistently across the affected functions, and the new error code is correctly defined and handled. The logic for trying subsequent authentication methods is preserved and now clearer. I have reviewed the changes and found no issues.
sumit-bose
force-pushed
the
otp_offine_password
branch
from
0bf6d72 to
afa50be
Compare
thalman
left a comment
thalman
left a comment
There was a problem hiding this comment.
Looks goos, thanks @sumit-bose
|
@sumit-bose, should this go to sssd-2-9 as well? |
Hi, the issue was cause by the bye, |
|
@shridhargadekar, @sumit-bose, is this something to account for in #8032? |
Hi, I think not because it si not related to bye, |
I think @spoore1 or maybe @krishnavema or @ikerexxe should know. |
No idea, I never played with 2FA |
This error code should be used if another authentication type should be checked. Resolves: SSSD#8108 Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
This patch used the new error code ERR_CHECK_NEXT_AUTH_TYPE while processing different authentication types instead of EAGAIN because EAGAIN might have side effects when returned to the callers. Resolves: SSSD#8108 Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com>
sssd-bot
force-pushed
the
otp_offine_password
branch
from
afa50be to
89db64f
Compare
|
Note: Covscan was green. |
5 participants
This patch used the new error code ERR_CHECK_NEXT_AUTH_TYPE while
processing different authentication types instead of EAGAIN because
EAGAIN might have side effects when returned to the callers.
Resolves: #8108