[autobackport: sssd-2-11] krb5_child: use ERR_CHECK_NEXT_AUTH_TYPE instead of EAGAIN #8230
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request backports a change to replace the generic EAGAIN error code with a more specific ERR_CHECK_NEXT_AUTH_TYPE when iterating through different authentication methods in krb5_child. This improves code clarity and robustness by avoiding potential side effects of using EAGAIN. The changes include defining the new error code and its string representation, and consistently replacing EAGAIN in krb5_child.c where it's used to signal trying the next authentication method. A clarifying comment has also been added to explain the handling of EAGAIN when returned from krb5_get_init_creds_password(), which is a different use case. The changes are correct and a good improvement to the codebase. I have not found any issues.
sumit-bose
force-pushed
the
SSSD-sssd-backport-pr8176-to-sssd-2-11
branch
from
3a0e67e to
bf8763a
Compare
This patch used the new error code ERR_CHECK_NEXT_AUTH_TYPE while processing different authentication types instead of EAGAIN because EAGAIN might have side effects when returned to the callers. Resolves: SSSD#8108 Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit 0adc2e7)
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit da82d1d)
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8176-to-sssd-2-11
branch
from
bf8763a to
455b4e4
Compare
4 participants
This is an automatic backport of PR#8176 krb5_child: use ERR_CHECK_NEXT_AUTH_TYPE instead of EAGAIN to branch sssd-2-11, created by @sumit-bose.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
7ddb51f - utils: add new error code ERR_CHECK_NEXT_AUTH_TYPE
0adc2e7 - krb5_child: use ERR_CHECK_NEXT_AUTH_TYPE instead of EAGAIN
da82d1d - krb5_child: clarify EAGAIN returned by krb5_get_init_creds_password()
Backported commits
Original Pull Request Body
This patch used the new error code ERR_CHECK_NEXT_AUTH_TYPE while
processing different authentication types instead of EAGAIN because
EAGAIN might have side effects when returned to the callers.
Resolves: #8108