Skip to content

fix(timeline): fix blank room timeline when app returns from background #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 3 commits into from
Apr 10, 2026
+19 −3
Merged

fix(timeline): fix blank room timeline when app returns from background #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42b7582
fix(timeline): re-arm initial-scroll when TimelineReset blanks the view
Just-Insane Apr 9, 2026
dc5dbfd
fix(timeline): show skeleton placeholders while timeline reloads on f…
Just-Insane Apr 9, 2026
3aacd91
chore: add changeset for timeline-blank-on-foreground fix
Just-Insane Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-timeline-blank-on-foreground.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

Fix blank room timeline when app returns from background. When sliding sync delivers an `initial: true` response for the open room, a `TimelineReset` event now correctly shows skeleton placeholders while events reload instead of leaving an empty view.
17 changes: 14 additions & 3 deletions src/app/features/room/RoomTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,17 @@ export function RoomTimeline({
[]
);

// If the timeline was blanked while content was already visible — e.g. a
// TimelineReset fired by mx.retryImmediately() when the app comes back from
// background — hide the timeline (opacity 0) and re-arm the initial-scroll so
// it runs again once events refill the live timeline.
useLayoutEffect(() => {
if (!isReady) return;
if (timelineSync.eventsLength > 0) return;
setIsReady(false);
hasInitialScrolledRef.current = false;
}, [isReady, timelineSync.eventsLength]);

const recalcTopSpacer = useCallback(() => {
const v = vListRef.current;
if (!v) return;
Expand Down Expand Up @@ -640,7 +651,7 @@ export function RoomTimeline({

const showLoadingPlaceholders =
timelineSync.eventsLength === 0 &&
(timelineSync.canPaginateBack || timelineSync.backwardStatus === 'loading');
(!isReady || timelineSync.canPaginateBack || timelineSync.backwardStatus === 'loading');

let backPaginationJSX: ReactNode | undefined;
if (timelineSync.canPaginateBack || timelineSync.backwardStatus !== 'idle') {
Expand Down Expand Up @@ -708,7 +719,7 @@ export function RoomTimeline({

const vListItemCount =
timelineSync.eventsLength === 0 &&
(timelineSync.canPaginateBack || timelineSync.backwardStatus === 'loading')
(!isReady || timelineSync.canPaginateBack || timelineSync.backwardStatus === 'loading')
? 3
: timelineSync.eventsLength;
const vListIndices = useMemo(
Expand Down Expand Up @@ -840,7 +851,7 @@ export function RoomTimeline({
minHeight: 0,
overflow: 'hidden',
position: 'relative',
opacity: isReady ? 1 : 0,
opacity: isReady || showLoadingPlaceholders ? 1 : 0,
}}
>
<VList<ProcessedEvent>
Expand Down
Loading