fix(timeline): fix blank room timeline when app returns from background#657
Merged
7w1 merged 3 commits intoSableClient:devfrom Apr 10, 2026
Merged
Conversation
When the app returns from background, retryImmediately() triggers a fresh sliding sync response. If the server includes initial:true for the open room, the SDK emits RoomEvent.TimelineReset, replacing the live timeline with a new empty one. eventsLength drops to 0 but isReady stays true, leaving the message list visible but empty for ~500 ms until events re-arrive. Add a useLayoutEffect that detects eventsLength dropping to 0 while the timeline is already visible (isReady === true). It hides the content (opacity 0) and resets hasInitialScrolledRef so the initial-scroll effect re-arms. When events refill the timeline the existing 80 ms scroll timer fires again and sets isReady back to true, revealing the content.
7w1
approved these changes
Apr 10, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add support for rendering bundled urls per MSC4095 ([#590](#590) by @nushea) * Improve code blocks with faster, more accurate syntax highlighting, broader language support, and separate light and dark theme options. ([#576](#576) by @hazre) * Add statuses to DMs ([#644](#644) by @nushea) * Add custom DM images and descriptions ([#644](#644) by @nushea) * Add statuses to Member Tile ([#644](#644) by @nushea) * Add the ability to set Global Name Colors dependent on the theme (dark/light) ([#656](#656) by @nushea) * Add a setting to collapse sidebar folders by default. ([#624](#624) by @7w1) * Add a "Dismiss" button to command response messages. ([#625](#625) by @7w1) * Update threads: various fixes, browse all room threads, and see live reply counts on messages. ([#564](#564) by @Just-Insane) * Re-introduced custom HTML formatting for long messages ([#641](#641) by @Septicity) * You can now share direct links to specific settings, and opening one takes you to the right section and highlights the target option. ([#577](#577) by @hazre) * Settings now use route-based navigation with improved desktop and mobile behavior, including better back and close handling. ([#577](#577) by @hazre) ## Fixes * Use file name instead of "a voice message" for non-voice audio files. ([#651](#651) by @mvanhorn) * Constrain bug report modal to viewport height to prevent overflow. ([#652](#652) by @mvanhorn) * Fix dms navigation not navigating to dms when local storage is messed up. ([#653](#653) by @7w1) * Fix reply button not capturing editor focus. ([#623](#623) by @7w1) * Fixes links not being clickable in formatted messages, including messages that use abbreviations. ([#632](#632) by @hazre) * Fix some zero-width (invisible) names ([#640](#640) by @nushea) * Fix iOS elastic bounce-back overscroll on the root element. ([#650](#650) by @mvanhorn) * Fixed the "sticky scrolling" issue in encrypted rooms with many PMP messages. ([#626](#626) by @Septicity) * Fix blank room timeline when app returns from background. When sliding sync delivers an `initial: true` response for the open room, a `TimelineReset` event now correctly shows skeleton placeholders while events reload instead of leaving an empty view. ([#657](#657) by @Just-Insane) * Image zooming is now centered on the cursor position ([#602](#602) by @mini-bomba) * Image zooming is now multiplicative instead of additive, resulting in a consistent "zooming speed". ([#602](#602) by @mini-bomba) * Image zoom buttons now zoom towards the center of the screen ([#602](#602) by @mini-bomba) * Right clicks no longer drag images in the viewer. ([#620](#620) by @Septicity) * Updated Support links to point to https://opencollective.com/sable ([#661](#661) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the app returns from background,
retryImmediately()triggers a fresh sliding sync response. If the server includesinitial: truefor the currently open room, the SDK emitsRoomEvent.TimelineReset, replacing the live timeline with a new empty one.eventsLengthdrops to 0 butisReadystaystrue, leaving the message list visually blank for ~500 ms until events re-arrive from the server.Changes
RoomTimeline.tsxAdded a
useLayoutEffectthat detectseventsLengthdropping to 0 while the timeline is already visible (isReady === true). It immediately setsisReady = falseand resetshasInitialScrolledRef, re-arming the existing initial-scroll logic. UsesuseLayoutEffectso the transition happens before the browser paints — the blank frame is never shown.Expanded
showLoadingPlaceholders,vListItemCount, and the containeropacityto include the!isReadycase, so skeleton placeholders are shown immediately during the reload rather than leaving an invisible list.Before / After
Fixes #
Type of change
Checklist:
AI disclosure:
Fully AI generated (explain what all the generated code does in moderate detail).
The
useLayoutEffectguard and the three!isReadycondition expansions were fully AI generated. The effect fires synchronously before paint wheneventsLengthdrops to 0 on an already-visible timeline, hides content and resets the initial-scroll flag. The existing 80 ms scroll timer then re-runs once events refill and callssetIsReady(true). TheshowLoadingPlaceholders/vListItemCountchanges ensure VList renders 3 placeholder skeleton rows (matching the existing pagination-loading behaviour) while events are absent.