Skip to content

Fix invisible names#640

Merged
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks
Apr 5, 2026
Merged

Fix invisible names#640
7w1 merged 1 commit intoSableClient:devfrom
nushea:fix-blanks

Conversation

@nushea
Copy link
Copy Markdown
Contributor

@nushea nushea commented Apr 5, 2026

Description

Small change to attempt to default to the right name so that they do not show as being blank

Had to be a hard list because there does not seem to be a list of characters that are supposed to be blank within the \p type

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

A million monkeys spent a million years typing out the implementation

@nushea nushea requested review from 7w1 and hazre as code owners April 5, 2026 02:49
7w1
7w1 approved these changes Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A million monkeys spent a million years typing out the implementation

Impressive monkeys

@7w1 7w1 added this pull request to the merge queue Apr 5, 2026
Merged via the queue into SableClient:dev with commit 0ae47b6 Apr 5, 2026
12 checks passed
@sable-release-bot sable-release-bot bot mentioned this pull request Apr 5, 2026
Merged
@nushea
Copy link
Copy Markdown
Contributor Author

nushea commented Apr 5, 2026

A million monkeys spent a million years typing out the implementation

Impressive monkeys

it was quite a challenge teaching them regex, a lot of trouble getting them to stop writing all the works of Shakespear

@nushea nushea deleted the fix-blanks branch April 5, 2026 03:16
@nushea nushea restored the fix-blanks branch April 7, 2026 04:00
@nushea nushea mentioned this pull request Apr 7, 2026
Merged
11 tasks
github-merge-queue bot pushed a commit that referenced this pull request Apr 7, 2026
@7w1
Minor tweak to the blank name check (#649)
e1f1168 
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Small change to the function because apparently (at least firefox) only
supports 4byte unicode so it fails to resolve some names due to the
5byte variation checker, and added the regular blanks just in case
because they should be (are afaik for most major homeservers) stripped
by the homeserver but not always

This is doesnt need a changeset since it is a 1 line change in a pr from
the same version

Fixes regression in #640

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
The Architect AGI threatened to unplug me if i didnt make the fix 👍🏻
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2026
@7w1
chore: prepare release 1.14.0 (#603)
6a895f8 
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add support for rendering bundled urls per MSC4095
([#590](#590) by @nushea)
* Improve code blocks with faster, more accurate syntax highlighting,
broader language support, and separate light and dark theme options.
([#576](#576) by @hazre)
* Add statuses to DMs
([#644](#644) by @nushea)
* Add custom DM images and descriptions
([#644](#644) by @nushea)
* Add statuses to Member Tile
([#644](#644) by @nushea)
* Add the ability to set Global Name Colors dependent on the theme
(dark/light) ([#656](#656) by
@nushea)
* Add a setting to collapse sidebar folders by default.
([#624](#624) by @7w1)
* Add a "Dismiss" button to command response messages.
([#625](#625) by @7w1)
* Update threads: various fixes, browse all room threads, and see live
reply counts on messages.
([#564](#564) by @Just-Insane)
* Re-introduced custom HTML formatting for long messages
([#641](#641) by @Septicity)
* You can now share direct links to specific settings, and opening one
takes you to the right section and highlights the target option.
([#577](#577) by @hazre)
* Settings now use route-based navigation with improved desktop and
mobile behavior, including better back and close handling.
([#577](#577) by @hazre)

## Fixes

* Use file name instead of "a voice message" for non-voice audio files.
([#651](#651) by @mvanhorn)
* Constrain bug report modal to viewport height to prevent overflow.
([#652](#652) by @mvanhorn)
* Fix dms navigation not navigating to dms when local storage is messed
up. ([#653](#653) by @7w1)
* Fix reply button not capturing editor focus.
([#623](#623) by @7w1)
* Fixes links not being clickable in formatted messages, including
messages that use abbreviations.
([#632](#632) by @hazre)
* Fix some zero-width (invisible) names
([#640](#640) by @nushea)
* Fix iOS elastic bounce-back overscroll on the root element.
([#650](#650) by @mvanhorn)
* Fixed the "sticky scrolling" issue in encrypted rooms with many PMP
messages. ([#626](#626) by
@Septicity)
* Fix blank room timeline when app returns from background. When sliding
sync delivers an `initial: true` response for the open room, a
`TimelineReset` event now correctly shows skeleton placeholders while
events reload instead of leaving an empty view.
([#657](#657) by @Just-Insane)
* Image zooming is now centered on the cursor position
([#602](#602) by @mini-bomba)
* Image zooming is now multiplicative instead of additive, resulting in
a consistent "zooming speed".
([#602](#602) by @mini-bomba)
* Image zoom buttons now zoom towards the center of the screen
([#602](#602) by @mini-bomba)
* Right clicks no longer drag images in the viewer.
([#620](#620) by @Septicity)
* Updated Support links to point to https://opencollective.com/sable
([#661](#661) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes

@hazre hazre Awaiting requested review from hazre hazre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nushea @7w1