feat(threads): thread drawer, thread browser, live reply counts, and unread badges#564
Merged
7w1 merged 6 commits intoSableClient:devfrom Apr 10, 2026
Merged
Conversation
29282cb to
740e69c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end Matrix thread support across the room timeline: a thread drawer for reading/replying in-thread, a thread browser listing room threads (with pagination), and live reply/unread indicators, backed by Matrix SDK threadSupport.
Changes:
- Enable SDK thread tracking by passing
threadSupport: truetostartClient(classic + sliding sync). - Introduce shared edit-mode hook (
useMessageEdit) and wire it throughRoomTimeline/timeline actions andThreadDrawer. - Implement thread UI primitives:
ThreadDrawerported to the shared timeline rendering pipeline,ThreadBrowserbacked by/threads+ pagination/backfill, and live reply/unread badges on timeline thread chips.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/client/initMatrix.ts | Enables Matrix SDK thread support in both classic and sliding sync start paths. |
| src/app/hooks/useMessageEdit.ts | New hook to centralize edit-mode state/reset/focus behavior for composers. |
| src/app/hooks/timeline/useTimelineEventRenderer.tsx | Adds live thread reply/unread chip updates; supports suppressing thread chip/reply headers inside drawer. |
| src/app/hooks/timeline/useTimelineActions.ts | Refactors timeline actions to accept shared handleEdit instead of owning edit state. |
| src/app/hooks/timeline/useProcessedTimeline.ts | Adds skipThreadFilter to allow processing thread timelines without filtering out replies. |
| src/app/features/room/ThreadDrawer.tsx | Reworks thread drawer to use shared timeline processing/rendering; adds sequential loading/backfill and edit-last-message support. |
| src/app/features/room/ThreadBrowser.tsx | Adds server-backed thread list with load-more pagination, root-event backfill, and unread badges. |
| src/app/features/room/RoomTimeline.tsx | Adopts useMessageEdit and passes handleEdit into timeline actions. |
| src/app/features/common-settings/developer-tools/DevelopTools.tsx | Adds thread diagnostics + “fetch from server” action for debugging thread state. |
| .changeset/feat-thread-enhancements.md | Declares a minor release note for thread support features. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Just-Insane
added a commit
to Just-Insane/Sable
that referenced
this pull request
Mar 28, 2026
- useTimelineEventRenderer.tsx: Use Math.max(thread.length, replyEvents.length) to avoid undercounting replies when only a subset of events is loaded locally. - ThreadBrowser.tsx: Use Math.max(thread.length, localReplyCount) to show correct total even for threads whose timeline hasn't been fully paginated. - ThreadDrawer.tsx: Align showClientUrlPreview logic with RoomTimeline: require both clientUrlPreview AND encClientUrlPreview in encrypted rooms. - useMessageEdit.ts: Minor wording: 'never stales' → 'never goes stale'.
Just-Insane
added a commit
to Just-Insane/Sable
that referenced
this pull request
Mar 28, 2026
- useTimelineEventRenderer.tsx: Use Math.max(thread.length, replyEvents.length) to avoid undercounting replies when only a subset of events is loaded locally. - ThreadBrowser.tsx: Use Math.max(thread.length, localReplyCount) to show correct total even for threads whose timeline hasn't been fully paginated. - ThreadDrawer.tsx: Align showClientUrlPreview logic with RoomTimeline: require both clientUrlPreview AND encClientUrlPreview in encrypted rooms. - useMessageEdit.ts: Minor wording: 'never stales' → 'never goes stale'.
d3520ef to
6709a58
Compare
Member
7w1
requested changes
Mar 31, 2026
Member
|
Wait why do we need a button? Can’t be just load more when the user scrolls up like a normal timeline? I must be getting something confused lol. |
62ad79a to
76333bd
Compare
Removed comments explaining reply count logic.
7w1
approved these changes
Apr 10, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add support for rendering bundled urls per MSC4095 ([#590](#590) by @nushea) * Improve code blocks with faster, more accurate syntax highlighting, broader language support, and separate light and dark theme options. ([#576](#576) by @hazre) * Add statuses to DMs ([#644](#644) by @nushea) * Add custom DM images and descriptions ([#644](#644) by @nushea) * Add statuses to Member Tile ([#644](#644) by @nushea) * Add the ability to set Global Name Colors dependent on the theme (dark/light) ([#656](#656) by @nushea) * Add a setting to collapse sidebar folders by default. ([#624](#624) by @7w1) * Add a "Dismiss" button to command response messages. ([#625](#625) by @7w1) * Update threads: various fixes, browse all room threads, and see live reply counts on messages. ([#564](#564) by @Just-Insane) * Re-introduced custom HTML formatting for long messages ([#641](#641) by @Septicity) * You can now share direct links to specific settings, and opening one takes you to the right section and highlights the target option. ([#577](#577) by @hazre) * Settings now use route-based navigation with improved desktop and mobile behavior, including better back and close handling. ([#577](#577) by @hazre) ## Fixes * Use file name instead of "a voice message" for non-voice audio files. ([#651](#651) by @mvanhorn) * Constrain bug report modal to viewport height to prevent overflow. ([#652](#652) by @mvanhorn) * Fix dms navigation not navigating to dms when local storage is messed up. ([#653](#653) by @7w1) * Fix reply button not capturing editor focus. ([#623](#623) by @7w1) * Fixes links not being clickable in formatted messages, including messages that use abbreviations. ([#632](#632) by @hazre) * Fix some zero-width (invisible) names ([#640](#640) by @nushea) * Fix iOS elastic bounce-back overscroll on the root element. ([#650](#650) by @mvanhorn) * Fixed the "sticky scrolling" issue in encrypted rooms with many PMP messages. ([#626](#626) by @Septicity) * Fix blank room timeline when app returns from background. When sliding sync delivers an `initial: true` response for the open room, a `TimelineReset` event now correctly shows skeleton placeholders while events reload instead of leaving an empty view. ([#657](#657) by @Just-Insane) * Image zooming is now centered on the cursor position ([#602](#602) by @mini-bomba) * Image zooming is now multiplicative instead of additive, resulting in a consistent "zooming speed". ([#602](#602) by @mini-bomba) * Image zoom buttons now zoom towards the center of the screen ([#602](#602) by @mini-bomba) * Right clicks no longer drag images in the viewer. ([#620](#620) by @Septicity) * Updated Support links to point to https://opencollective.com/sable ([#661](#661) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Docs: Already live at Threads — Sable Docs — no separate docs PR needed.
Description
Expands Matrix thread support with a full thread drawer, server-side thread browser, live reply counts, unread badges, and several UX fixes.
ThreadDrawer
m.relates_to.event_idnotthreadRootIddirectly — fetches target event to check thread membership)maxHeight: 200pxto avoid dead whitespace on short messagesThreadBrowser
room.fetchRoomThreads()on mount to load threads beyond the local timeline windowuseRoomNavigate) instead of re-opening the drawerroom.getThreadUnreadNotificationCount()ThreadReplyChip (main timeline)
room.getThreadUnreadNotificationCount()Thread button (RoomViewHeader)
aria-pressedreflects both thread browser state and open thread drawerFixes #
Type of change
Checklist:
AI disclosure:
ThreadDrawer/ThreadBrowser/thread-chip iterations were partially AI assisted; I reviewed and adjusted logic for timeline processing, thread loading, and event rendering behavior.