Skip to content

feat: route settings and add setting links#577

Merged
7w1 merged 21 commits intodevfrom
hazre/feat/settings-routing-links
Apr 1, 2026
Merged

feat: route settings and add setting links#577
7w1 merged 21 commits intodevfrom
hazre/feat/settings-routing-links

Conversation

@hazre
Copy link
Copy Markdown
Member

@hazre hazre commented Mar 28, 2026

Description

This PR reworks settings into route-driven navigation instead of local component state. Settings now use canonical /settings/<section> URLs, render as a shallow modal on desktop, render full-page on mobile, and use route-based open, close, and back behavior so the shell and history handling stay consistent.

It also adds shareable settings links with ?focus= targets. Those links can be copied from setting rows, render as internal setting-link pills in chat, route back into the app, and flash the targeted setting after navigation. The settings link base URL is configurable, dynamic per-device rows do not expose copy links because they are not stable across clients, and the settings-specific Permalink naming has been cleaned up to SettingLink for consistency.

Screenshots

Recording.2026-03-28.200658.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

This PR moves settings state into the router, adds the shallow desktop modal route renderer and mobile full-page settings flow, introduces canonical settings-link parsing/building plus chat rendering/interception for those links, adds focus-target highlighting and configurable settings-link base URL handling, and polishes the row-level copy-link controls and naming so the settings-link codepath is internally consistent.

@hazre hazre requested a review from 7w1 as a code owner March 28, 2026 19:13
@hazre
Copy link
Copy Markdown
Member Author

hazre commented Mar 30, 2026

God damnit, my own PR is causing me to resolve a merge conflict

hazre added 3 commits March 30, 2026 23:29
…uting-links

# Conflicts:
#	src/app/plugins/react-custom-html-parser.test.tsx
#	src/app/plugins/react-custom-html-parser.tsx
…uting-links

# Conflicts:
#	src/app/plugins/react-custom-html-parser.test.tsx
@github-actions
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-577-sable.raspy-dream-bb1d.workers.dev ae66ba6 pr-577 Tue, 31 Mar 2026 12:21:40 GMT

@7w1 7w1 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into dev with commit 67093c5 Apr 1, 2026
12 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add support for rendering bundled urls per MSC4095
([#590](#590) by @nushea)
* Improve code blocks with faster, more accurate syntax highlighting,
broader language support, and separate light and dark theme options.
([#576](#576) by @hazre)
* Add statuses to DMs
([#644](#644) by @nushea)
* Add custom DM images and descriptions
([#644](#644) by @nushea)
* Add statuses to Member Tile
([#644](#644) by @nushea)
* Add the ability to set Global Name Colors dependent on the theme
(dark/light) ([#656](#656) by
@nushea)
* Add a setting to collapse sidebar folders by default.
([#624](#624) by @7w1)
* Add a "Dismiss" button to command response messages.
([#625](#625) by @7w1)
* Update threads: various fixes, browse all room threads, and see live
reply counts on messages.
([#564](#564) by @Just-Insane)
* Re-introduced custom HTML formatting for long messages
([#641](#641) by @Septicity)
* You can now share direct links to specific settings, and opening one
takes you to the right section and highlights the target option.
([#577](#577) by @hazre)
* Settings now use route-based navigation with improved desktop and
mobile behavior, including better back and close handling.
([#577](#577) by @hazre)

## Fixes

* Use file name instead of "a voice message" for non-voice audio files.
([#651](#651) by @mvanhorn)
* Constrain bug report modal to viewport height to prevent overflow.
([#652](#652) by @mvanhorn)
* Fix dms navigation not navigating to dms when local storage is messed
up. ([#653](#653) by @7w1)
* Fix reply button not capturing editor focus.
([#623](#623) by @7w1)
* Fixes links not being clickable in formatted messages, including
messages that use abbreviations.
([#632](#632) by @hazre)
* Fix some zero-width (invisible) names
([#640](#640) by @nushea)
* Fix iOS elastic bounce-back overscroll on the root element.
([#650](#650) by @mvanhorn)
* Fixed the "sticky scrolling" issue in encrypted rooms with many PMP
messages. ([#626](#626) by
@Septicity)
* Fix blank room timeline when app returns from background. When sliding
sync delivers an `initial: true` response for the open room, a
`TimelineReset` event now correctly shows skeleton placeholders while
events reload instead of leaving an empty view.
([#657](#657) by @Just-Insane)
* Image zooming is now centered on the cursor position
([#602](#602) by @mini-bomba)
* Image zooming is now multiplicative instead of additive, resulting in
a consistent "zooming speed".
([#602](#602) by @mini-bomba)
* Image zoom buttons now zoom towards the center of the screen
([#602](#602) by @mini-bomba)
* Right clicks no longer drag images in the viewer.
([#620](#620) by @Septicity)
* Updated Support links to point to https://opencollective.com/sable
([#661](#661) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants