Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#626
Merged
7w1 merged 1 commit intoSableClient:devfrom Apr 2, 2026
Merged
Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#6267w1 merged 1 commit intoSableClient:devfrom
7w1 merged 1 commit intoSableClient:devfrom
Conversation
7w1
approved these changes
Apr 2, 2026
11 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
…ticky scroll fix (#645) ### Description In [this PR](#626), I fixed the sticky scrolling issue by disabling the automatic timeline regroup for PMP messages, since this event repeatedly scrolled the user to the bottom of the page in encrypted rooms with many PMP messages. However, this change _did_ end up regressing the functionality of that fix: Albeit extremely irregularly, some PMP messages will fail to be grouped together or will otherwise not have their profile picture load. To fix this, I've reintroduced the timeline regroup logic, but I've replaced the regroup function to a different room event that still provides a visual refresh without doing any scrolling. As the previous PR hasn't made it to a public release yet, I'm not including a changeset, as it serves the same purpose as and would have ideally been included in the original PR. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings ### AI disclosure: - [x] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. --> I used AI to quickly trace exactly what each event type does and format the new `room.emit` line. As opposed to the Timeline event from before, the LocalEchoUpdated event should refresh the timeline without any automatic scrolling. This should make sure that PMP messages are properly regrouped automatically, and my testing confirms this.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add support for rendering bundled urls per MSC4095 ([#590](#590) by @nushea) * Improve code blocks with faster, more accurate syntax highlighting, broader language support, and separate light and dark theme options. ([#576](#576) by @hazre) * Add statuses to DMs ([#644](#644) by @nushea) * Add custom DM images and descriptions ([#644](#644) by @nushea) * Add statuses to Member Tile ([#644](#644) by @nushea) * Add the ability to set Global Name Colors dependent on the theme (dark/light) ([#656](#656) by @nushea) * Add a setting to collapse sidebar folders by default. ([#624](#624) by @7w1) * Add a "Dismiss" button to command response messages. ([#625](#625) by @7w1) * Update threads: various fixes, browse all room threads, and see live reply counts on messages. ([#564](#564) by @Just-Insane) * Re-introduced custom HTML formatting for long messages ([#641](#641) by @Septicity) * You can now share direct links to specific settings, and opening one takes you to the right section and highlights the target option. ([#577](#577) by @hazre) * Settings now use route-based navigation with improved desktop and mobile behavior, including better back and close handling. ([#577](#577) by @hazre) ## Fixes * Use file name instead of "a voice message" for non-voice audio files. ([#651](#651) by @mvanhorn) * Constrain bug report modal to viewport height to prevent overflow. ([#652](#652) by @mvanhorn) * Fix dms navigation not navigating to dms when local storage is messed up. ([#653](#653) by @7w1) * Fix reply button not capturing editor focus. ([#623](#623) by @7w1) * Fixes links not being clickable in formatted messages, including messages that use abbreviations. ([#632](#632) by @hazre) * Fix some zero-width (invisible) names ([#640](#640) by @nushea) * Fix iOS elastic bounce-back overscroll on the root element. ([#650](#650) by @mvanhorn) * Fixed the "sticky scrolling" issue in encrypted rooms with many PMP messages. ([#626](#626) by @Septicity) * Fix blank room timeline when app returns from background. When sliding sync delivers an `initial: true` response for the open room, a `TimelineReset` event now correctly shows skeleton placeholders while events reload instead of leaving an empty view. ([#657](#657) by @Just-Insane) * Image zooming is now centered on the cursor position ([#602](#602) by @mini-bomba) * Image zooming is now multiplicative instead of additive, resulting in a consistent "zooming speed". ([#602](#602) by @mini-bomba) * Image zoom buttons now zoom towards the center of the screen ([#602](#602) by @mini-bomba) * Right clicks no longer drag images in the viewer. ([#620](#620) by @Septicity) * Updated Support links to point to https://opencollective.com/sable ([#661](#661) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, in encrypted rooms with many PMP messages, scrolling to the bottom of the page resulted in the view "sticking"; you would need to scroll either very quickly or manually with the scrollbar to get "unstuck".
This stemmed from a part of the logic for grouping PMP messages together in encrypted rooms; a timeline update seemed to be erroneously triggered, re-rendering the timeline repeatedly (effectively sending you back to the bottom).
I've removed the offending line, and the original functionality of the change (i.e. PMP messages continuing to be grouped both as they are sent, edited, and re-rendered) seems to still be present.
Type of change
Checklist:
AI disclosure: