Skip to content

feat: center image zooming on the cursor#602

Merged
dozro merged 2 commits intoSableClient:devfrom
mini-bomba:feat/centered-zoom
Mar 31, 2026
Merged

feat: center image zooming on the cursor#602
dozro merged 2 commits intoSableClient:devfrom
mini-bomba:feat/centered-zoom

Conversation

@mini-bomba
Copy link
Copy Markdown
Contributor

@mini-bomba mini-bomba commented Mar 30, 2026 •
edited
Loading

Description

This PR makes the image zooming via double-click or mouse wheel centered on the cursor position rather than the center of the image.
Clicking the zoom % label (between + and - buttons) now resets the image zoom and pan.
Zooming was also changed from being additive to multiplicative, which makes the "zooming speed" feel consistent.

In the process of doing this I merged the zoom and pan state into one, making it possible to change them at the same time.
The setPan and setZoom functions were recreated for compatibility. resetTransforms was added for convenience.
handleWheel was moved from the ImageViewer into the image gestures hook.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@mini-bomba mini-bomba requested review from 7w1 and hazre as code owners March 30, 2026 22:50
7w1
7w1 reviewed Mar 31, 2026
View reviewed changes
7w1
7w1 approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm other than that 1 optional comment

@mini-bomba mini-bomba requested a review from 7w1 March 31, 2026 09:35
@dozro dozro added this pull request to the merge queue Mar 31, 2026
7w1
7w1 approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Merged via the queue into SableClient:dev with commit ab80d33 Mar 31, 2026
12 checks passed
@sable-release-bot sable-release-bot bot mentioned this pull request Mar 31, 2026
Merged
@mini-bomba mini-bomba deleted the feat/centered-zoom branch March 31, 2026 14:41
github-merge-queue bot pushed a commit that referenced this pull request Apr 10, 2026
@7w1
chore: prepare release 1.14.0 (#603)
6a895f8 
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add support for rendering bundled urls per MSC4095
([#590](#590) by @nushea)
* Improve code blocks with faster, more accurate syntax highlighting,
broader language support, and separate light and dark theme options.
([#576](#576) by @hazre)
* Add statuses to DMs
([#644](#644) by @nushea)
* Add custom DM images and descriptions
([#644](#644) by @nushea)
* Add statuses to Member Tile
([#644](#644) by @nushea)
* Add the ability to set Global Name Colors dependent on the theme
(dark/light) ([#656](#656) by
@nushea)
* Add a setting to collapse sidebar folders by default.
([#624](#624) by @7w1)
* Add a "Dismiss" button to command response messages.
([#625](#625) by @7w1)
* Update threads: various fixes, browse all room threads, and see live
reply counts on messages.
([#564](#564) by @Just-Insane)
* Re-introduced custom HTML formatting for long messages
([#641](#641) by @Septicity)
* You can now share direct links to specific settings, and opening one
takes you to the right section and highlights the target option.
([#577](#577) by @hazre)
* Settings now use route-based navigation with improved desktop and
mobile behavior, including better back and close handling.
([#577](#577) by @hazre)

## Fixes

* Use file name instead of "a voice message" for non-voice audio files.
([#651](#651) by @mvanhorn)
* Constrain bug report modal to viewport height to prevent overflow.
([#652](#652) by @mvanhorn)
* Fix dms navigation not navigating to dms when local storage is messed
up. ([#653](#653) by @7w1)
* Fix reply button not capturing editor focus.
([#623](#623) by @7w1)
* Fixes links not being clickable in formatted messages, including
messages that use abbreviations.
([#632](#632) by @hazre)
* Fix some zero-width (invisible) names
([#640](#640) by @nushea)
* Fix iOS elastic bounce-back overscroll on the root element.
([#650](#650) by @mvanhorn)
* Fixed the "sticky scrolling" issue in encrypted rooms with many PMP
messages. ([#626](#626) by
@Septicity)
* Fix blank room timeline when app returns from background. When sliding
sync delivers an `initial: true` response for the open room, a
`TimelineReset` event now correctly shows skeleton placeholders while
events reload instead of leaving an empty view.
([#657](#657) by @Just-Insane)
* Image zooming is now centered on the cursor position
([#602](#602) by @mini-bomba)
* Image zooming is now multiplicative instead of additive, resulting in
a consistent "zooming speed".
([#602](#602) by @mini-bomba)
* Image zoom buttons now zoom towards the center of the screen
([#602](#602) by @mini-bomba)
* Right clicks no longer drag images in the viewer.
([#620](#620) by @Septicity)
* Updated Support links to point to https://opencollective.com/sable
([#661](#661) by @7w1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes

@hazre hazre Awaiting requested review from hazre hazre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mini-bomba @7w1 @dozro