Skip to content

fix: handling of missing value in removeRows/removeRowsByColumn#1001

Merged
lars-reimann merged 1 commit intomainfrom
998-use-new-polars-remove-method
Mar 9, 2025
Merged

fix: handling of missing value in removeRows/removeRowsByColumn#1001
lars-reimann merged 1 commit intomainfrom
998-use-new-polars-remove-method

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Mar 9, 2025

Closes #998

Summary of Changes

Table.removeRows and Table.removeRowsByColumn now keep missing values, i.e. they only remove rows for which the predicate returns True.

@lars-reimann lars-reimann linked an issue Mar 9, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON mypy 5 0 3.33s
✅ PYTHON ruff 5 0 0 0.29s
✅ REPOSITORY git_diff yes no 0.28s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (447d0cf) to head (f203653).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         135      135           
  Lines        8213     8213           
=======================================
  Hits         7836     7836           
  Misses        377      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lars-reimann lars-reimann merged commit f30d1f4 into main Mar 9, 2025
11 checks passed
@lars-reimann lars-reimann deleted the 998-use-new-polars-remove-method branch March 9, 2025 14:11
lars-reimann pushed a commit that referenced this pull request May 3, 2025
## [0.30.1](v0.30.0...v0.30.1) (2025-05-03)

### Bug Fixes

* handling of missing value in `removeRows`/`removeRowsByColumn` ([#1001](#1001)) ([f30d1f4](f30d1f4)), closes [#998](#998)
* wrong type hint ([eea9f05](eea9f05))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use new polars remove method

1 participant