Skip to content

fix: handling of missing value in removeRows/removeRowsByColumn #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lars-reimann merged 1 commit into from
Mar 9, 2025
Merged

fix: handling of missing value in removeRows/removeRowsByColumn #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/safeds/data/tabular/containers/_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,7 @@ def remove_rows(
mask = predicate(_LazyVectorizedRow(self))

return Table._from_polars_lazy_frame(
self._lazy_frame.filter(~mask._polars_expression),
self._lazy_frame.remove(mask._polars_expression),
)

def remove_rows_by_column(
Expand Down Expand Up @@ -1592,7 +1592,7 @@ def remove_rows_by_column(
mask = predicate(_LazyCell(pl.col(name)))

return Table._from_polars_lazy_frame(
self._lazy_frame.filter(~mask._polars_expression),
self._lazy_frame.remove(mask._polars_expression),
)

def remove_rows_with_missing_values(
Expand Down
6 changes: 6 additions & 0 deletions tests/safeds/data/tabular/containers/_table/test_filter_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,19 @@
lambda row: row["col1"] <= 2,
Table({"col1": [1, 2]}),
),
(
lambda: Table({"col1": [None]}),
lambda row: row["col1"] <= 2,
Table({"col1": []}),
),
],
ids=[
"empty",
"no rows",
"no matches",
"some matches",
"only matches",
"None",
],
)
class TestHappyPath:
Expand Down
7 changes: 7 additions & 0 deletions tests/safeds/data/tabular/containers/_table/test_filter_rows_by_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,19 @@
lambda cell: cell <= 2,
Table({"col1": [1, 2], "col2": [-1, -2]}),
),
(
lambda: Table({"col1": [None], "col2": [None]}),
"col1",
lambda cell: cell <= 2,
Table({"col1": [], "col2": []}),
),
],
ids=[
"no rows",
"no matches",
"some matches",
"only matches",
"None",
],
)
class TestHappyPath:
Expand Down
6 changes: 6 additions & 0 deletions tests/safeds/data/tabular/containers/_table/test_remove_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,19 @@
lambda row: row["col1"] <= 2,
Table({"col1": []}),
),
(
lambda: Table({"col1": [None]}),
lambda row: row["col1"] <= 2,
Table({"col1": [None]}),
),
],
ids=[
"empty",
"no rows",
"no matches",
"some matches",
"only matches",
"None",
],
)
class TestHappyPath:
Expand Down
7 changes: 7 additions & 0 deletions tests/safeds/data/tabular/containers/_table/test_remove_rows_by_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,19 @@
lambda cell: cell <= 2,
Table({"col1": [], "col2": []}),
),
(
lambda: Table({"col1": [None], "col2": [None]}),
"col1",
lambda cell: cell <= 2,
Table({"col1": [None], "col2": [None]}),
),
],
ids=[
"no rows",
"no matches",
"some matches",
"only matches",
"None",
],
)
class TestHappyPath:
Expand Down