Skip to content

feat: improve table.summary. Catch ValueError thrown by column.stability#390

Merged
alex-senger merged 5 commits intomainfrom
320-tablesummary-raises-an-error-if-one-column-contains-only-null-values
Jun 23, 2023
Merged

feat: improve table.summary. Catch ValueError thrown by column.stability#390
alex-senger merged 5 commits intomainfrom
320-tablesummary-raises-an-error-if-one-column-contains-only-null-values

Conversation

@alex-senger
Copy link
Contributor

Closes #320

Summary of Changes

The stability of a column with only null values should just be skipped and displayed in the returned table as a minus: -

…tability`

Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
@alex-senger alex-senger requested a review from a team as a code owner June 23, 2023 13:56
@lars-reimann
Copy link
Member

lars-reimann commented Jun 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 4 0 0 1.06s
✅ PYTHON mypy 4 0 2.36s
✅ PYTHON ruff 4 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

megalinter-bot and others added 3 commits June 23, 2023 13:58
…n that contains only None

Co-authored-by: patrikguempel <128832338+patrikguempel@users.noreply.github.com>
…-if-one-column-contains-only-null-values' into 320-tablesummary-raises-an-error-if-one-column-contains-only-null-values
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #390 (c8f7958) into main (d97d32a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2353      2355    +2     
=========================================
+ Hits          2353      2355    +2     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_column.py 100.00% <100.00%> (ø)
src/safeds/data/tabular/containers/_table.py 100.00% <100.00%> (ø)

Copy link
Contributor

@sibre28 sibre28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-senger alex-senger enabled auto-merge (squash) June 23, 2023 14:18
@alex-senger alex-senger merged commit dbbe0e3 into main Jun 23, 2023
@alex-senger alex-senger deleted the 320-tablesummary-raises-an-error-if-one-column-contains-only-null-values branch June 23, 2023 14:23
lars-reimann pushed a commit that referenced this pull request Jun 30, 2023
## [0.14.0](v0.13.0...v0.14.0) (2023-06-30)

### Features

* 290 properties for width-height of image ([#359](#359)) ([d9ebdc1](d9ebdc1)), closes [#290](#290)
* Add `find_edges` method to `Image` class ([#383](#383)) ([d14b6ce](d14b6ce)), closes [#288](#288)
* Add `StandardScaler` transformer ([#316](#316)) ([57b0572](57b0572)), closes [#142](#142)
* Add docstrings to the getter methods for hyperparameters in Regression and Classification models ([#371](#371)) ([9073f04](9073f04)), closes [#313](#313)
* Added `Table.group_by` to group a table by a given key ([#343](#343)) ([afb98be](afb98be)), closes [#160](#160)
* Added and improved errors and warnings in the table transformers ([#372](#372)) ([544e307](544e307)), closes [#152](#152)
* added crop() method in image and tests ([#365](#365)) ([eba8163](eba8163))
* added invert_colors method ([#367](#367)) ([1e4d110](1e4d110))
* adjust brightness and contrast of image ([#368](#368)) ([1752feb](1752feb)), closes [#289](#289) [#291](#291)
* blur Image method ([#363](#363)) ([c642176](c642176))
* check that methods of table can handle an empty table ([#314](#314)) ([686c2e7](686c2e7)), closes [#123](#123)
* convert image to grayscale ([#366](#366)) ([1312fe7](1312fe7)), closes [#287](#287)
* enhance `replace_column` to accept a list of new columns ([#312](#312)) ([d50c5b5](d50c5b5)), closes [#301](#301)
* Explicitly throw `UnknownColumnNameError` in `TaggedTable._from_table` ([#334](#334)) ([498999f](498999f)), closes [#333](#333)
* flip images / eq method for image ([#360](#360)) ([54f4ae1](54f4ae1)), closes [#280](#280)
* improve `table.summary`. Catch `ValueError` thrown by `column.stability` ([#390](#390)) ([dbbe0e3](dbbe0e3)), closes [#320](#320)
* improve error handling of `column.stability` when given a column that contains only None ([#388](#388)) ([1da2499](1da2499)), closes [#319](#319)
* Improve Error Handling of classifiers and regressors ([#355](#355)) ([66f5f64](66f5f64)), closes [#153](#153)
* Resize image ([#354](#354)) ([3a971ca](3a971ca)), closes [#283](#283)
* rotate_left and rotate_right added to Image ([#361](#361)) ([c877530](c877530)), closes [#281](#281)
* set kernel of support vector machine ([#350](#350)) ([1326f40](1326f40)), closes [#172](#172)
* sharpen image ([#364](#364)) ([3444700](3444700)), closes [#286](#286)

### Bug Fixes

* Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 ([#386](#386)) ([15dab06](15dab06)), closes [#318](#318)
* remove default value of `positive_class` parameter of classifier metrics ([#382](#382)) ([58fc09e](58fc09e))
* remove default value of `radius` parameter of `blur` ([#378](#378)) ([7f07f29](7f07f29))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table.summary raises an error if one column contains only null values

4 participants