Conversation
Contributor
Author
|
Merge this after #52 |
elimillera
approved these changes
Apr 22, 2021
Contributor
elimillera
left a comment
elimillera
left a comment
There was a problem hiding this comment.
One question but looks good
| domain: multiple | ||
| pacakage: Tplyr | ||
| package: safetyCharts | ||
| workflow: |
Contributor
There was a problem hiding this comment.
Does this yaml need the export?
Contributor
Author
There was a problem hiding this comment.
Doesn't hurt to add it, but will default to TRUE if nothing is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates/deletes functions in the inst/config/workflow folder:
/R/tplyr_shift_chart.R. This seems to deal with the dependency issues and fix the shift table, which now renders. Still need to do tplyr renderers not working in newest safetyGraphics Build #53 before v1.0 to have full safetyGraphics functionality./R/mod_lab_distribution.Rand add documentation./inst/config/workflow/safety_histogram_chart.Rfor now. Will deal with that in WIP: safetyHistogram updates #45Test notes
Confirm that shift table and lab distribution work as expected in safetyGraphics and in the exported html.