Conversation
Contributor
|
Per SafetyGraphics/safetyGraphics#522, I reviewed the charts and they looked all good to me with the exception of the Hepatic Explorer |
elimillera
approved these changes
Apr 21, 2021
Contributor
Author
|
Let's make sure that hep-explorer is working for someone other than me before we merge. @xni7 @samussiah @bzkrouse - could one of you take a quick look and see if it runs in the app and export? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR along with SafetyGraphics/safetyGraphics#526 fixes issues in htmlwidget reporting. Including those in #49.
Now all standard renderers expect for AE Timelines should be working well in safetyGraphics reports. See #51 for a summary of the AE Timelines issues.
Test Notes.
Same as SafetyGraphics/safetyGraphics#526 - Make sure all exported charts work as expected using the following branches: