Skip to content

Fix 515 506#522

Merged
jwildfire merged 4 commits intodevfrom
fix-515-506
Apr 21, 2021
Merged

Fix 515 506#522
jwildfire merged 4 commits intodevfrom
fix-515-506

Conversation

@jwildfire
Copy link
Contributor

Summary

Clean up inst and migrate to new data filter mod. close #515 and #506.

Test notes

Just make sure the app is still running as expected, with a special focus on the data filter functionality.

@jwildfire jwildfire requested review from samussiah and xni7 April 19, 2021 15:35
@jwildfire jwildfire requested a review from elimillera April 20, 2021 17:22
@elimillera
Copy link
Contributor

Just went through everything. I'm not able to get the Hepatic Safety Explorer to load. I'm not sure if this is just an issue with my environment or not.

Everything else looked good to me though. I tested the filtering on every chart and they all looked to take that into account.

@jwildfire
Copy link
Contributor Author

Thanks @elimillera. Will merge this up in the morning.

Were there any errors in the R console or in the javascript console in the web browser (hit ctrl-shift-j in chrome to open)related to hep-explorer? If there's nothing obvious, I might ask you to re-create bug this on our next Friday call so that we can take a look together and see if we can figure out what is going on.

@jwildfire jwildfire merged commit e63f56b into dev Apr 21, 2021
@jwildfire
Copy link
Contributor Author

Going to go ahead and merge here, since there were no changes to hep-explorer. Will work on sorting out the bug in a separate issue/PR.

@jwildfire jwildfire deleted the fix-515-506 branch April 21, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from Esquisse to datamods for participant filtering

2 participants