Skip to content

Add Export flag to charts#526

Merged
jwildfire merged 6 commits intodevfrom
reports-updates
Apr 26, 2021
Merged

Add Export flag to charts#526
jwildfire merged 6 commits intodevfrom
reports-updates

Conversation

@jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Apr 20, 2021

Summary

Adds support for a new Export flag in chart config objects. If the flag is true, the chart shows up on the reports list, if false it doesn't. If no export flag is set, it defaults to true. The flag is currently overridden when type="module" since they cannot be exported.

With the updates here and in safetyCharts SafetyGraphics/safetyCharts#52 all charts should have basic functionality in the exported html document.

Test notes

Make sure all exported charts work as expected using the following branches:

devtools::install_github("safetyGraphics/safetyCharts", ref="fix-49")
library(safetyCharts)
devtools::install_github("safetyGraphics/safetyGraphics", ref="reports-updates")
library(safetyGraphics)
safetyGraphics::safetyGraphicsApp()

@jwildfire jwildfire self-assigned this Apr 21, 2021
@jwildfire jwildfire requested a review from elimillera April 26, 2021 03:03
Copy link
Contributor

@elimillera elimillera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still having trouble with the Hepatic Safety Explorer. I'm thinking it must be a package or a dependency I don't have.

Otherwise everything looks good.

@jwildfire jwildfire merged commit b57b604 into dev Apr 26, 2021
@jwildfire jwildfire deleted the reports-updates branch May 24, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants