Skip to content

Make meta #97

Merged
jwildfire merged 5 commits intodevfrom
make-meta-take2
Mar 15, 2022
Merged

Make meta #97
jwildfire merged 5 commits intodevfrom
make-meta-take2

Conversation

@jwildfire
Copy link
Contributor

In conjunction with SafetyGraphics/safetyGraphics#650

@xni7
Copy link
Contributor

xni7 commented Mar 6, 2022

@jwildfire , nice work! Tested makeMeta in a test repo of qtexplorer and it works fine. A side question is about harmonizing safetyCharts extension pkgs with safetyCharts. How would one consolidate meta data and js dependency libraries? wondering if meta_ecg needs to be ported to qtexplorer?

https://github.com/SafetyGraphics/qtexplorer/blob/master/tests/testthat/test_qtexp.R

@jwildfire jwildfire self-assigned this Mar 15, 2022
@jwildfire
Copy link
Contributor Author

A side question is about harmonizing safetyCharts extension pkgs with safetyCharts. How would one consolidate meta data and js dependency libraries? wondering if meta_ecg needs to be ported to qtexplorer?

@xni7 I'm not sure the best strategy regarding a meta_ecg migration. The main complication is with the QT versions of the safety widgets that currently live in safetyCharts. Moving those to a different repo should be possible, but might require a few tweaks that we'd have to talk though.

I'd like to finalize this release in the next week or 2, so I'll file an issue, but my preference would be to leave it as is until the next release.

@jwildfire
Copy link
Contributor Author

I'll file an issue

See #98

@jwildfire jwildfire merged commit c2f3a14 into dev Mar 15, 2022
@jwildfire jwildfire deleted the make-meta-take2 branch March 23, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants