Conversation
… provided for a given standard
xni7
left a comment
There was a problem hiding this comment.
@jwildfire , looks great! PR review notes
- Code review of makeMeta.R
- code looks good!
- Confirm all tests in test_makeMeta.R make sense and run as expected.
- All tests passed
- Review updates Examples 11 and 12 from the safetyGraphics cookbook vignette and confirm that code runs as expected.
- Example 11 works. Couldn't find Example 12
- Review updates to the safetyGraphics chart vignette
- Is chart vignette updated? don't see the new content
Had a minor comment about extending existing standard meta data.
elimillera
left a comment
There was a problem hiding this comment.
Great work! Some small comments/linting
Co-authored-by: Eli Miller <elimillera@gmail.com>
Co-authored-by: Eli Miller <elimillera@gmail.com>
Co-authored-by: Eli Miller <elimillera@gmail.com>
|
Thanks for the reviews @xni7 and @elimillera. I'll get chart vignette updated and then merge this once safetyCharts v0.3 is up on CRAN - going to try to clean it up and submit this week. Friendly reminder to take a look at SafetyGraphics/safetyCharts#103 if you have a chance - should be a relatively quick review! |
|
Updated example 5 and the appendices in the chart vignette. |
@jwildfire Just reviewed. Looks great! Just had a couple of minor comments. Btw, looks like you are an early 🐦!👍 😄 |
|
All checks passing now that safetyCharts v0.3 is on CRAN. Merging to dev. Will work on cleaning up vignettes and pkgdown, and aim for v2.1 release in the next week or so. |
Overview
This PR refactors safetyGraphics metadata workflow to allow users to easily add metadata for new charts without needing to update the
safetyGraphicspackage.Updates include:
safetyGraphics::metatosafetyCharts::meta_XXX(Make meta safetyCharts#97)safetyGraphics::makeMeta()function that allows more flexibility in storing metadata for new charts. (Migrate metadata storage to safetyCharts #637)safetyChartsTest Notes
Test in in conjunction with SafetyGraphics/safetyCharts#97
makeMeta.Rtest_makeMeta.Rmake sense and run as expected.Fixes #637