Skip to content

Mapping refactor#587

Merged
jwildfire merged 6 commits intodevfrom
mapping-refactor
Jun 18, 2021
Merged

Mapping refactor#587
jwildfire merged 6 commits intodevfrom
mapping-refactor

Conversation

@jwildfire
Copy link
Contributor

@jwildfire jwildfire commented Jun 17, 2021

Overview

Updated the mapping page so that the user has the option to view a data set preview while completing the mapping process as shown below.

image

Fixes #560 #579.

Test Notes

Play with the new mapping page and make sure nothing major is broken.

@jwildfire jwildfire self-assigned this Jun 17, 2021
@xni7
Copy link
Contributor

xni7 commented Jun 17, 2021

Very nice feature! only comment is it does not show side by side
image

@jwildfire
Copy link
Contributor Author

jwildfire commented Jun 17, 2021

Can you try again now, @xni7?

I was having trouble getting fluidRow() to behave, so I just did the layout in css. I just going to move to fixed width for now, so the data/chart should be side-by-side if window is at least 1000px wide. I also filed #588 to make it reactive; maybe someone who is better with css or shiny layouts can tackle it - @samussiah or @MayaGans? Otherwise, I think it can probably wait until after v2.0.

@xni7
Copy link
Contributor

xni7 commented Jun 17, 2021

fe5ef9e works! DT table a little narrow, but should be ok.
image

@jwildfire
Copy link
Contributor Author

@xni7 Made a few more formatting tweaks, and think it's looking good now. Want to give it one more quick review on your end before I merge?

@xni7
Copy link
Contributor

xni7 commented Jun 18, 2021

Yes it looks great now!

@jwildfire jwildfire merged commit ef6dc75 into dev Jun 18, 2021
@jwildfire jwildfire deleted the mapping-refactor branch June 18, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Mapping Side-by-side with data preview

2 participants