fix: remove python as a required property in tool.poetry.dependencies#4413
Merged
hyperupcall merged 1 commit intoFeb 18, 2025
Merged
Conversation
Member
|
Thanks! Is good to undraft now? Seems to be included in v2.1.0 |
felixgwilliams
requested review from
hyperupcall and
madskristensen
as code owners
Member
|
Thanks! (I'm going to review and "request changes" to test out one of our GitHub actions, but after that, I will merge this!) |
hyperupcall
approved these changes
Feb 18, 2025
Member
|
LGTM |
Contributor
|
There was an issue merging, maybe try again hyperupcall. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since poetry v2, the
tool.poetry.dependenciessection no longer requires a version specifier for python.A PR to update the poetry documents accordingly has been merged here. I will mark this PR as ready once the document update is live.
This pull request reflects this by removing
pythonas a required property and adds a test example that has atool.poetry.dependenciessection without apythonproperty.