feat: Change depencendies.poetry to optional.#4434
Conversation
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
|
Thanks! Looks like a dupe of #4413 - I'll be merging that one since it was first and keeps the |
| } | ||
| }, | ||
| "patternProperties": { | ||
| "^(?!python$)[a-zA-Z-_.0-9]+$": { |
There was a problem hiding this comment.
Do you think this change should be a separate PR? I wouldn't be surprised if this fixes validation errors when a person wants to specify a non-cpython version of Python. But I'm just speculating
There was a problem hiding this comment.
Yes, it is required.
With python no longer required, it is simpler to write.
And another problem is that some libraries do not support lookahead regular expressions, so this fix is more desirable.
Create another PR.
There was a problem hiding this comment.
I see, thank you for the info
2 participants
In poetry v2, the python version is now specified in project.requires-python,
so
tool.poetry.dependencies.pythonis no longer required.