Add the github build actions for Vulkan#794
Merged
martindevans merged 1 commit intoSciSharp:monsky_temp_pr_branchfrom Jun 18, 2024
m0nsky:vulkan_build_actions
Merged
Add the github build actions for Vulkan#794martindevans merged 1 commit intoSciSharp:monsky_temp_pr_branchfrom m0nsky:vulkan_build_actions
martindevans merged 1 commit intoSciSharp:monsky_temp_pr_branchfrom
m0nsky:vulkan_build_actions
Conversation
Member
|
Would you mind kicking off a test run of the "Update Binaries" build action in your fork? If that completes successfully we can merge this PR. |
Contributor
Author
|
Is this something that should be done locally or through github? I've tried looking around on the "Actions" page on my fork but can't find anything there. |
Member
Contributor
Author
|
Yeah, that page is empty, and that setting is set to "Allow all", just checked it again. |
Member
|
We're merging this into a new temporary branch called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Haven't got any experience with contributing to and opening PR's in repos other than private/local, so let's give this a try. This PR adds the required build actions for Vulkan so the binaries can be built.
If I have understood the previous discussion correctly and this PR goes well, I will:
And finally I will look into auto loading of the library under Windows and WSL, I will see if I can find someone with an AMD GPU to help with the testing. If this goes well also, I would be fine with maintaining the parser.