Script to make PR authors aware if they are modifying templated files#41
Merged
ESadek-MO merged 12 commits intoSciTools:mainfrom Mar 20, 2025
Merged
Script to make PR authors aware if they are modifying templated files#41ESadek-MO merged 12 commits intoSciTools:mainfrom
ESadek-MO merged 12 commits intoSciTools:mainfrom
Conversation
ESadek-MO
requested changes
Mar 20, 2025
Contributor
ESadek-MO
left a comment
There was a problem hiding this comment.
This is really cool, seems to work really nicely and I haven't spotted anything worrying.
There's a couple of grammar type questions, but otherwise looks GTG.
Am I correct in thinking this will go in first, but won't be functional until actions on other repos are merged in?
trexfeathers
commented
Mar 20, 2025
Contributor
Author
trexfeathers
left a comment
There was a problem hiding this comment.
Am I correct in thinking this will go in first, but won't be functional until actions on other repos are merged in?
Correct. The good news is that it is not dependent on future hypothetical code. Best way to think of it is 'ready to go', and we have even demonstrated what the future workflows will look like.
ESadek-MO
approved these changes
Mar 20, 2025
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a few different permutations, plus I've made some minor changes to the existing
notify_updates()script, so I intend to produce some demonstrations of this all working before I take it out of draft.The demonstrations below use the
demo_templatingbranch. The only differences fromprompt-shareare those that enable demonstrations (see diff).notify_updates()The following issues were generated when the workflow ran against the same code used by this branch:
.pre-commit-config.yamlhas been updated trexfeathers/iris#91demo_1.pyhas been updated trexfeathers/cf-units#7Thus demonstrating that this PR does not break existing functionality
prompt_share()The new routine
Two demo pull requests
prompt-shareroutine trexfeathers/cf-units#8prompt-shareroutine trexfeathers/iris#92What these demonstrate
Proposal for actions on each repo
See these diffs, which introduce an identical new workflow on cf-units and iris (plus temporarily deleting the other workflows!)