Merged
Conversation
trexfeathers
commented
Mar 20, 2025
trexfeathers
commented
Mar 20, 2025
ESadek-MO
approved these changes
Mar 24, 2025
This was referenced Mar 24, 2025
|
All dependent PRs have now been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See SciTools/.github#41 for the detailed context. Will need calling workflows on each of our repos.
Do we still believe in the workflows repository?
I personally have experienced a lot of frustrations of having one workflow that affects all repositories, as it gets in the way of me introducing a new concept (e.g. #28), means mistakes have large impacts (e.g. #88 vs #93), and makes it difficult to test things (e.g #108).
Templating is an alternative way of achieving the same thing, without the above problems. HOWEVER: we have agreed among the core devs that templating needs to be demonstrated to work BEFORE we apply it to workflows. In the meantime I felt it was important to embrace our current way of working.
Dependent PRs
ci-template-check.ymltephi#206Plan to merge and test this before raising PRs on all the other repos
ci-template-check.ymliris#6377ci-template-check.ymliris-grib#628ci-template-check.ymlpython-stratify#330ci-template-check.ymliris-esmf-regrid#484ci-template-check.ymlcf-units#574ci-template-check.ymlnc-time-axis#344ci-template-check.ymltest-iris-imagehash#125ci-template-check-pr.yml#117