Merged
Conversation
Member
|
Looks like this relates to metarelate/metOcean#20 |
Member
Author
|
this pull request does not include the 'MKS' units instances which also cause udunits to raise an exception. I am awaiting feedback from the code owner on these and I will update this pull request accordingly |
Member
Author
|
this is now complete and ready to merge, from my pov |
Member
There was a problem hiding this comment.
Is this right? psu is practical salinity unit, right?
Member
Author
There was a problem hiding this comment.
PSU is practical salinity units, it is dimensionless
the 1e3 factor and the 0.035 offset are the information we are provided with to correctly scale the values from unity
I believe this is correct, and consistent with the CF standard name canonical unit
Member
|
One query, but otherwise I'm happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates to units of measure for udunits validity + recent field code updates