Skip to content

translation rework#1155

Merged
pp-mo merged 2 commits intoSciTools:masterfrom
marqh:transrework
Jun 19, 2014
Merged

translation rework#1155
pp-mo merged 2 commits intoSciTools:masterfrom
marqh:transrework

Conversation

@marqh
Copy link
Member

@marqh marqh commented Jun 3, 2014

updates to field code management; translations moved from rules into metarelate

All changes reviewed and committed to metarelate's metocean information store

this pull request incorporates all changes from #965 and #989, which is supercedes

this pull request also includes translations from #1145 and #1154 and may be better merged after these

@marqh marqh mentioned this pull request Jun 3, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Units of kg/kg, m3/m3? Really? Is there a reason for not having units of '1'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is significantly preferred by the user community

e.g.: kg/kg and mol/mol are interpreted quite differently from certain scientific perspectives. Although both have units of '1' from a mathematical perspective, the scientific interpretation is different and our user community is keen to preserve this information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've certainly seen a lot of opinion that prefers "kg/kg", so I'm OK with this.

I've yet to be convinced "the scientific interpretation is different" - rather that some people use the unit as an alternative/adjunct to the standard name. But that's a different battle... 😑

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting given the units of '1' listed in the cf standard name table. I won't lose any sleep over it, but don't expect such units to be preserved if performing calculations e.g.:

>>> iris.unit.Unit('kg/kg') * 'm'
Unit('meter')

@marqh
Copy link
Member Author

marqh commented Jun 18, 2014

@pp-mo this replaces #965 which you raised.

please may you review this PR and assess whether #965 may be closed and this merged in its place?

@pp-mo
Copy link
Member

pp-mo commented Jun 19, 2014

incorporates all changes from #965 and #989, which it supercedes

checked for #989, all good

@pp-mo
Copy link
Member

pp-mo commented Jun 19, 2014

incorporates all changes from #965 and #989, which it supercedes

checked for #965, all good

pp-mo added a commit that referenced this pull request Jun 19, 2014
@pp-mo pp-mo merged commit 395c61d into SciTools:master Jun 19, 2014
@pp-mo
Copy link
Member

pp-mo commented Jun 19, 2014

Ok, looks fine now
Thanks @marqh
-- end of a long sorry saga !

@pp-mo pp-mo mentioned this pull request Jun 25, 2014
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants