Fieldsfile and PP support for unpacked and CRAY 32-bit packed data.

[bjlittle]

No description provided.

[pelson]

A brief review suggests this looks good to go.
I know @MartinDix is interested in this functionality. Martin - are you in a position to try this out on your own data?

Cheers,

[pelson]

I know @MartinDix is interested in this functionality.

I might be wrong actually. Before @MartinDix puts any effort into this, @bjlittle do you think this PR addresses #185?

[rhattersley]

I might be wrong actually. Before @MartinDix puts any effort into this, @bjlittle do you think this PR addresses #185?

It does address part of the problem mentioned (namely LBPACK being 0 or 2 for a 64-bit fieldsfile), but it doesn't tackle 32-bit fieldsfiles .... that's the part @MartinDix has offered to tackle once this PR is merged.

[rhattersley]

As yet I've only given it a quick skim, but it looks like an excellent change. Just the kind of thing I was hoping for. :-)

And as I think it'll be the first PR to introduce the mock module, could you add it to the INSTALL file please.

[rhattersley]

Long line.

[rhattersley]

There are quite a few long lines in this method.

[rhattersley]

Should the use of "pp" (e.g. in "_pp_payload", "pp_field", and the like) be removed? Is this just a hangover from copying the pp module?

[rhattersley]

Some minor formatting and refactoring... but otherwise lookin' good, and I'm itching to get it merged. :-)

[MartinDix]

This works properly with our 64 bit files with LBPACK=0 and 2. Thanks.

[rhattersley]

This works properly with our 64 bit files with LBPACK=0 and 2. Thanks.

Thanks for the feedback :-)

[pelson]

👍 good work @bjlittle. Thanks for testing @MartinDix.