Merged
Conversation
lib/iris/fileformats/cf.py
Outdated
Member
There was a problem hiding this comment.
At what point do you populate the self._attr_cache dictionary?
Member
Author
There was a problem hiding this comment.
Damn you copy & paste!! 😠 I missed a line.
Which reminds me, I was going to write a test to prove the caching is working! 😉
Member
There was a problem hiding this comment.
Consider yourself demoted from demi-god to mortal.
Welcome to the club!
Contributor
There was a problem hiding this comment.
I make that semi-demi, actually. Like the quaver.
Member
Author
|
NB. The test uses the "mock" module so shouldn't really be merged until after #210. |
Member
Author
|
I'd like to try a tweak before this gets merged - I'll update once I've tested it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.