Possible citation updates -- not clear whether appropriate.#5453
Merged
trexfeathers merged 2 commits intoSciTools:v3.7.xfrom Dec 7, 2023
Merged
Possible citation updates -- not clear whether appropriate.#5453trexfeathers merged 2 commits intoSciTools:v3.7.xfrom
trexfeathers merged 2 commits intoSciTools:v3.7.xfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.7.x #5453 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 89 89
Lines 22443 22443
Branches 5381 5381
=======================================
Hits 20058 20058
Misses 1639 1639
Partials 746 746 ☔ View full report in Codecov by Sentry. |
Contributor
Member
Author
|
@SciTools/peloton Connects to #5161 ? |
pp-mo
commented
Dec 7, 2023
revert conversion to url -- it should be a bare DOI
trexfeathers
approved these changes
Dec 7, 2023
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 13, 2023
* main: Adopt inital noop ruff linter (SciTools#5623) Update links to https (SciTools#5621) Bump actions/stale from 8 to 9 (SciTools#5616) Faster and simpler iris.util.array_equal (SciTools#5610) Updated environment lockfiles (SciTools#5608) Bump actions/setup-python from 4 to 5 (SciTools#5614) Possible citation updates -- not clear whether appropriate. (SciTools#5453) Whats new updates for v3.7.0 . (SciTools#5451)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unclear whether these changes folllow the correct form, but I suspect anyway that the existing format where it says "doi = {10.5281/zenodo.7386117}" is possibly wrong : this is not a complete valid url.
TBDUPDATE it is a doi, should not be a url (!)