Skip to content

Compare tests#70

Merged
pp-mo merged 16 commits intomainfrom
compare_tests
Jun 25, 2024
Merged

Compare tests#70
pp-mo merged 16 commits intomainfrom
compare_tests

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Apr 12, 2024

Proper testing for the compare-datasets operation.
And completion of, as this is uncovering bugs and missing functionality in it.

Current status 2024-04-12
Ongoing, still writing full tests . Possibly now overcomplicated + needs careful review
several fixes + missing features already addressed in here

Status 2024-05-30:
see comment

@pp-mo pp-mo mentioned this pull request Apr 12, 2024
6 tasks
@pp-mo
Copy link
Member Author

pp-mo commented May 31, 2024

Possible remaining:

  • review API docstrings (again)
  • mock tests for calls to variable_differences from dataset_differences
  • can variable_differences compare actual netCDF4.Variables ?
  • changelog ?

@pp-mo pp-mo marked this pull request as ready for review May 31, 2024 10:48
@pp-mo pp-mo mentioned this pull request Jun 10, 2024
@pp-mo pp-mo linked an issue Jun 10, 2024 that may be closed by this pull request
@pp-mo pp-mo merged commit b283f31 into main Jun 25, 2024
@pp-mo pp-mo mentioned this pull request Jun 25, 2024
@pp-mo pp-mo mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish dataset comparison

1 participant