fix: rollback risky legacy db merge flow#230
Merged
code-JDS merged 1 commit intoScience-Discovery:devfrom Apr 9, 2026
Merged
Conversation
Replace the multi-database merge path with a conservative latest-db copy so missing targets can be recovered without risking existing user data.
lixfrank
requested review from
code-JDS,
shellmind112 and
yqmaphy
as code owners
|
The following comment was made by an LLM, it may be inaccurate: This PR may overlap with existing open pull requests:
Please check whether this work should be consolidated. |
code-JDS
approved these changes
Apr 9, 2026
shellmind112
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #229
Type of change
What does this PR do?
This rolls back the risky multi-database legacy merge path to a conservative copy-only flow. If
aether-prod.dbalready exists we now do nothing; otherwise we copy the newest.dbin the data directory toaether-prod.dband copy its.db-wal/.db-shmsidecars when present. The PR also removes the old agent-driven merge path, drops the unused merge-verification code and tests, and removes the success popup so startup stays quiet unless the copy fails.How did you verify your code works?
PATH="/Users/lx/miniconda3/bin:/Users/lx/miniconda3/condabin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin" bun typecheckinpackages/opencodePATH="/Users/lx/miniconda3/bin:/Users/lx/miniconda3/condabin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin" bun test test/storage/legacy-db.test.tsinpackages/opencodeScreenshots / recordings
Not applicable.
Checklist