Skip to content

feat: add interactive ROI dashboard#1147

Closed
CelebrityPunks wants to merge 1 commit intoScottcjn:mainfrom
CelebrityPunks:feat/miner-roi-dashboard
Closed

feat: add interactive ROI dashboard#1147
CelebrityPunks wants to merge 1 commit intoScottcjn:mainfrom
CelebrityPunks:feat/miner-roi-dashboard

Conversation

@CelebrityPunks
Copy link
Copy Markdown
Contributor

Web-based ROI calculator with live epoch data and adjustable parameters.

@github-actions
Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Your PR has a BCOS-L1 or BCOS-L2 label
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions bot added the size/S PR: 11-50 lines label Mar 15, 2026
Copy link
Copy Markdown

@achievefibromyalgia-lgtm achievefibromyalgia-lgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: #1147

Verdict: ✅ Approved!

Copy link
Copy Markdown
Contributor

@kuanglaodi2-sudo kuanglaodi2-sudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: PR #1147

Reviewed. Code looks good.


@kuanglaodi2-sudo

@Scottcjn Scottcjn closed this Mar 15, 2026
mgrigajtis pushed a commit to mgrigajtis/Rustchain that referenced this pull request Mar 16, 2026
…#711)

* fix: Scottcjn#1147 /attest/submit 500 crash with root-cause fix

- Add top-level exception handler to prevent 500 errors from propagating
- Harden validate_fingerprint_data() with defensive type checking for:
  - bridge_type (non-string values)
  - device_arch/device_arch (non-string values)
  - x86_features (non-list values)
- Add 10 regression tests covering malformed input scenarios
- Add comprehensive fix documentation

All existing tests pass + 10 new regression tests verify no 500 crashes.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

* docs: add PR link and bounty wallet to FIX_1147 docs

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

---------

Co-authored-by: createkr <createkr@proton.me>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
createkr added a commit to createkr/Rustchain that referenced this pull request Mar 22, 2026
…#711)

* fix: Scottcjn#1147 /attest/submit 500 crash with root-cause fix

- Add top-level exception handler to prevent 500 errors from propagating
- Harden validate_fingerprint_data() with defensive type checking for:
  - bridge_type (non-string values)
  - device_arch/device_arch (non-string values)
  - x86_features (non-list values)
- Add 10 regression tests covering malformed input scenarios
- Add comprehensive fix documentation

All existing tests pass + 10 new regression tests verify no 500 crashes.


* docs: add PR link and bounty wallet to FIX_1147 docs


---------

Co-authored-by: createkr <createkr@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR: 11-50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants