Skip to content

fix: #1147 /attest/submit 500 crash (clean scope)#711

Merged
Scottcjn merged 2 commits intoScottcjn:mainfrom
createkr:feat/issue1147-attest-fix-v2
Mar 8, 2026
Merged

fix: #1147 /attest/submit 500 crash (clean scope)#711
Scottcjn merged 2 commits intoScottcjn:mainfrom
createkr:feat/issue1147-attest-fix-v2

Conversation

@createkr
Copy link
Copy Markdown
Contributor

@createkr createkr commented Mar 8, 2026

Replacement for closed #695 with strict fix-only scope. Contains only: node validation fix, attestation fuzz test, and fix documentation. No MCP server/protocol bundling.\n\nPayout wallet: RTC1d48d848a5aa5ecf2c5f01aa5fb64837daaf2f35 (split option: createkr-wallet).

createkr and others added 2 commits March 9, 2026 00:23
- Add top-level exception handler to prevent 500 errors from propagating
- Harden validate_fingerprint_data() with defensive type checking for:
  - bridge_type (non-string values)
  - device_arch/device_arch (non-string values)
  - x86_features (non-list values)
- Add 10 regression tests covering malformed input scenarios
- Add comprehensive fix documentation

All existing tests pass + 10 new regression tests verify no 500 crashes.

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
@createkr createkr requested a review from Scottcjn as a code owner March 8, 2026 23:35
@github-actions github-actions bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related tests Test suite changes size/M PR: 51-200 lines labels Mar 8, 2026
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented Mar 8, 2026

Good defensive fix — type checking on claimed_arch, SIMD cross-validation, parameterized regression tests. Merging. 10 RTC to createkr.

@Scottcjn Scottcjn merged commit e1e791c into Scottcjn:main Mar 8, 2026
11 checks passed
createkr pushed a commit to createkr/Rustchain that referenced this pull request Mar 8, 2026
… changes

- Add airdrop_v2 import and endpoint registration to node file
- Keep airdrop module standalone (no core logic in node file)
- Minimal changes: import + init_airdrop_routes registration only
- Resolved rebase conflicts onto origin/main (Scottcjn#711)
- All tests pass: 21 airdrop tests + 34 attestation tests

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Scottcjn pushed a commit that referenced this pull request Mar 8, 2026
* feat: implement RIP-305 cross-chain airdrop infrastructure (#1149)

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

* refactor: integrate airdrop V2 as standalone module with minimal node changes

- Add airdrop_v2 import and endpoint registration to node file
- Keep airdrop module standalone (no core logic in node file)
- Minimal changes: import + init_airdrop_routes registration only
- Resolved rebase conflicts onto origin/main (#711)
- All tests pass: 21 airdrop tests + 34 attestation tests

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

---------

Co-authored-by: createkr <createkr@proton.me>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
createkr added a commit to createkr/Rustchain that referenced this pull request Mar 22, 2026
…#711)

* fix: Scottcjn#1147 /attest/submit 500 crash with root-cause fix

- Add top-level exception handler to prevent 500 errors from propagating
- Harden validate_fingerprint_data() with defensive type checking for:
  - bridge_type (non-string values)
  - device_arch/device_arch (non-string values)
  - x86_features (non-list values)
- Add 10 regression tests covering malformed input scenarios
- Add comprehensive fix documentation

All existing tests pass + 10 new regression tests verify no 500 crashes.


* docs: add PR link and bounty wallet to FIX_1147 docs


---------

Co-authored-by: createkr <createkr@proton.me>
createkr added a commit to createkr/Rustchain that referenced this pull request Mar 22, 2026
* feat: implement RIP-305 cross-chain airdrop infrastructure (Scottcjn#1149)


* refactor: integrate airdrop V2 as standalone module with minimal node changes

- Add airdrop_v2 import and endpoint registration to node file
- Keep airdrop module standalone (no core logic in node file)
- Minimal changes: import + init_airdrop_routes registration only
- Resolved rebase conflicts onto origin/main (Scottcjn#711)
- All tests pass: 21 airdrop tests + 34 attestation tests


---------

Co-authored-by: createkr <createkr@proton.me>
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented Apr 2, 2026

Transfer confirmed — this was included in the batch settlement of 1,091 RTC to @createkr's wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) documentation Improvements or additions to documentation node Node server related size/M PR: 51-200 lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants