[Dependency] Add compatibility with Less 3.x#6447
Merged
jlukic merged 7 commits intoSemantic-Org:nextfrom Jun 21, 2018
Merged
Conversation
…matting Fixed some formatting
Any custom theme.config files will need to be updated to add the (multiple) option when including theme.less.
Member
|
@jlukic This fix is blocking some SUIR doc updates I'd like to make. I've tested the fix here with Less 2.x and 3.x and all is well. |
|
Hi, is there a way to track when this support will be released? |
Member
|
@JonRowe @maxmilton @stevewillard, I would suggest using a tool like http://greenkeeper.io to keep your dependencies up to date. You'll simply get a PR every time one of your dependencies is updated. |
|
@levithomason Github dependencies also lets me do this, but I was hoping for a way to see announcement of releases so I can go unpin the relevant version of less etc |
Member
|
I'll be releasing it today in a patch. I just need to confirm no compatibility issues. |
|
Still broken with less 3.0.4 and 3.5.2 for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed Issues
Semantic-Org/Semantic-UI-LESS#30
Description
The two issues are related to commits in Less: less/less.js@9fd1ef5 and less/less.js@77fde7e. The first change causes variables to be undefined, the second change makes the
.loadFonts()import the Google Fonts CSS incorrectly.Any custom theme.config files will need to be updated to add the (multiple) option when including theme.less.
Re-opened from Semantic-Org/Semantic-UI-LESS#44
CC @levithomason