[Dependency] Fix compatibility issue with less >= 3.5 due to math changes#6512
[Dependency] Fix compatibility issue with less >= 3.5 due to math changes#6512sciyoshi wants to merge 1 commit intoSemantic-Org:masterfrom
Conversation
|
For whats it's worth, this fixes the bug - :LGTM: |
|
@jlukic @levithomason Can we get a review on this PR? |
|
Applying this patch will break with the current build system (gulp-less@3.5.0): |
|
Is there anything preventing the fix introduced in fomantic/Fomantic-UI#97 from being merged here? |
|
I'm going to look into adding this as a patch. Got lost in the shuffle. Feel free to email me at jack@semantic-ui.com if there are breaking changes like this, github is difficult for me to parse notifications. |
|
Any idea on when this patch may find its way into the npm packages? |
|
I've validated this and merged it into I've also added some additional calc swaps here 4b4df6c I've updated our build pipeline to enforce a minimum build of gulp-less that supports the new syntax. As this will not work in older versions of less and will cause breaking changes. aae225a I'll make a note of the requirement for those using older versions of LESS with the less only package to update in the release notes. |
|
Does this mean that building Looks like a perfect storm of abandoned dependencies! :D |
A follow-up to #6447, there's a new change in less 3.5 for how calculations are handled. This PR avoids the current interpolation that's happening and simply uses
calc(). The compiled CSS will be a bit different but should work the same way.Closes Semantic-Org/Semantic-UI-LESS#30, Semantic-Org/Semantic-UI-LESS#46, #6470.